Skip to content

[release-4.6] Bug 1893809: fix pod creation deadlock #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 5, 2020
Merged

[release-4.6] Bug 1893809: fix pod creation deadlock #213

openshift-merge-robot merged 1 commit into from
Nov 5, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 2, 2020

This is an automated cherry-pick of #209

/assign squeed

@squeed
fix pod creation deadlock
c7b35a6 
Commit b5f89a6 introduced a deadlock on pod creation, but only for
multitenant mode.

The fix is to lock runningPods only when actually accessing it, rather than
broadly.

Fixes: 1890130
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 2, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2020

@openshift-cherrypick-robot: Bugzilla bug 1890130 has been cloned as Bugzilla bug 1893809. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1893809: fix pod creation deadlock

Details

In response to this:

[release-4.6] Bug 1890130: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1890130: fix pod creation deadlock [release-4.6] Bug 1893809: fix pod creation deadlock Nov 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Nov 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1893809, which is invalid:

  • expected dependent Bugzilla bug 1890130 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1893809: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 2, 2020
@danwinship
Copy link
Contributor

danwinship commented Nov 3, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 4, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2020

@openshift-bot: This pull request references Bugzilla bug 1893809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1890130 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1890130 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 4, 2020
@squeed
Copy link
Contributor

squeed commented Nov 4, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 4, 2020

@squeed: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed squeed mentioned this pull request Nov 4, 2020
Merged
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 12c67a9 into openshift:release-4.6 Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 5, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1893809 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1893809: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 5, 2020

@squeed: new pull request created: #217

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhat abhat Awaiting requested review from abhat

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@danwinship danwinship

@squeed squeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @danwinship @openshift-bot @squeed @sdodson @openshift-merge-robot