Skip to content

[release-4.5] Bug 1894784: fix pod creation deadlock #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 10, 2020
Merged

[release-4.5] Bug 1894784: fix pod creation deadlock #217

openshift-merge-robot merged 1 commit into from
Dec 10, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 5, 2020

This is an automated cherry-pick of #213

/assign squeed

@squeed
fix pod creation deadlock
cbc991b 
Commit b5f89a6 introduced a deadlock on pod creation, but only for
multitenant mode.

The fix is to lock runningPods only when actually accessing it, rather than
broadly.

Fixes: 1890130
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 5, 2020

@openshift-cherrypick-robot: Bugzilla bug 1893809 has been cloned as Bugzilla bug 1894784. Retitling PR to link against new bug.
/retitle [release-4.5] [release-4.6] Bug 1894784: fix pod creation deadlock

Details

In response to this:

[release-4.5] [release-4.6] Bug 1893809: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] [release-4.6] Bug 1893809: fix pod creation deadlock [release-4.5] [release-4.6] Bug 1894784: fix pod creation deadlock Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 5, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1894784, which is invalid:

  • expected dependent Bugzilla bug 1893809 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.5] [release-4.6] Bug 1894784: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 5, 2020
@squeed
Copy link
Contributor

squeed commented Dec 9, 2020

/bugzilla refresh
/retest

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 9, 2020

@squeed: This pull request references Bugzilla bug 1894784, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1893809 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1893809 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2020
@squeed
Copy link
Contributor

squeed commented Dec 9, 2020

/approve

@juanluisvaladas could you review this quickly, thanks!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@squeed
Copy link
Contributor

squeed commented Dec 9, 2020

/retitle [release-4.5] Bug 1894784: fix pod creation deadlock

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] [release-4.6] Bug 1894784: fix pod creation deadlock [release-4.5] Bug 1894784: fix pod creation deadlock Dec 9, 2020
@juanluisvaladas
Copy link
Contributor

juanluisvaladas commented Dec 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, openshift-cherrypick-robot, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 10, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0d49432 into openshift:release-4.5 Dec 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1894784 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1894784: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed squeed mentioned this pull request Dec 14, 2020
Merged
@squeed
Copy link
Contributor

squeed commented Dec 15, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2020
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Dec 15, 2020

@squeed: new pull request created: #234

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@squeed squeed Awaiting requested review from squeed

Assignees

@squeed squeed

@juanluisvaladas juanluisvaladas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @squeed @juanluisvaladas @openshift-bot @sdodson @openshift-merge-robot