Skip to content

Comments

Switch base image registry to quay.io#127

Merged
bparees merged 1 commit intoopenshift:masterfrom
dulek:master
Apr 30, 2021
Merged

Switch base image registry to quay.io#127
bparees merged 1 commit intoopenshift:masterfrom
dulek:master

Conversation

@dulek
Copy link
Contributor

@dulek dulek commented Apr 23, 2021

DockerHub imposes pull limits on images causing issues with building
this application. This commit switches it to use base image from
quay.io.

DockerHub imposes pull limits on images causing issues with building
this application. This commit switches it to use base image from
quay.io.
@dulek
Copy link
Contributor Author

dulek commented Apr 23, 2021

@bparees: This is to unblock 3.11 tests that seem to fail due to hitting DockerHub pull limits.

@bparees
Copy link
Contributor

bparees commented Apr 24, 2021

i think this competes with #125 which is needed to unblock multiarch

@dulek
Copy link
Contributor Author

dulek commented Apr 29, 2021

@bparees: I guess I'm okay with #125 as long as it won't break even more 3.11 testing because of the changed CMD. Quick look tells me that Jenkins job will be fine, but I have some doubts about the ones in e2e tests.

Also #125 isn't progressing for a while. Anything to help get it through?

@bparees
Copy link
Contributor

bparees commented Apr 29, 2021

Also #125 isn't progressing for a while. Anything to help get it through?

not sure, i've pinged Yaakov (the pr author)

@dulek
Copy link
Contributor Author

dulek commented Apr 30, 2021

@bparees: Looks like it'll take more time with #125. Could we consider temporarily proceeding with this in order to unblock openshift/origin#26070 which unblocks openshift-ansible e2e tests?

@bparees
Copy link
Contributor

bparees commented Apr 30, 2021

@adambkaplan @gabemontero @soltysh based on comments on #125 i think this is safe so i'm merging it, but if you see any test failures related to it, let me know and we'll revert it immediately.

@gabemontero
Copy link

@adambkaplan @gabemontero @soltysh based on comments on #125 i think this is safe so i'm merging it, but if you see any test failures related to it, let me know and we'll revert it immediately.

sounds like a plan

@bparees bparees merged commit 397f5ad into openshift:master Apr 30, 2021
@dulek
Copy link
Contributor Author

dulek commented Apr 30, 2021

Thanks! I'm retesting openshift/origin#26070, fingers crossed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants