Conversation
|
@gabemontero @adambkaplan @soltysh giving you guys a heads up on this one, please let me know when you've confirmed these changes are safe for your tests. |
I think there is enough direct usage in @yselkowitz 's accompanying openshift/origin PR to get sufficient validation @bparees There are some direct references to the ubi8 image like https://github.com/openshift/origin/pull/26072/files#diff-2743afa0b07bbf4dd58d08076cb9e16b645182ba82e83f9cc8a5575c29bf7db2R1 plus there are a lot spots where he has switched imagestreamtag refs from ruby:2.7 to ruby:2.7-ubi8 .... that moves things to I would be very surprised if So assuming openshift/origin#26072 looks OK in the morning I say let's move forward with this. But of course I'm fine waiting on feedback from @adambkaplan and @soltysh as well if they have any. thanks @yselkowitz / @bparees |
|
Getting the tests and this coordinated will take a bit more work. |
Similarly to what Gabe wrote earlier, from oc pov, most of the tests don't care about contents, as long as the image is present. |
|
@yselkowitz are you still working on this? anything you need from us here or on openshift/origin#26072 ? |
|
I am working on this (among many other things), but it looks like the origin PR can't be as self-isolated as I hoped, so it's going to take a bit longer to get a reviewable set of commits there. |
|
@yselkowitz: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
What is needed to get this in now? |
|
@yselkowitz it's a manual merge process (i can do it) so if all the vetting has been done that these changes are compatible w/ origin testing, i can do it. let me know. |
|
also needs to rebase per the git bot ...i.e. has needs-rebase label |
|
Just tested a manual Dockerfile build of this with ruby-27-centos7 but w/o the explicit scl enable commands, and the container builds and runs like that, so it seems the container-entrypoint is doing its job, and this should be backwards compatible. I rebased almost three weeks ago and there have been no new changes since; is the bot sleeping here? |
|
might be due to the hold |
|
/refresh |
|
[shrug] |
This is necessary for the build tests on other architectures, as the
centos S2I images are x86_64 only.