Skip to content

Use ubi8/ruby-27#125

Merged
bparees merged 1 commit intoopenshift:masterfrom
multi-arch:master
Jun 15, 2021
Merged

Use ubi8/ruby-27#125
bparees merged 1 commit intoopenshift:masterfrom
multi-arch:master

Conversation

@yselkowitz
Copy link
Contributor

This is necessary for the build tests on other architectures, as the
centos S2I images are x86_64 only.

@bparees
Copy link
Contributor

bparees commented Apr 13, 2021

@gabemontero @adambkaplan @soltysh giving you guys a heads up on this one, please let me know when you've confirmed these changes are safe for your tests.

@gabemontero
Copy link

@gabemontero @adambkaplan @soltysh giving you guys a heads up on this one, please let me know when you've confirmed these changes are safe for your tests.

I think there is enough direct usage in @yselkowitz 's accompanying openshift/origin PR to get sufficient validation @bparees

There are some direct references to the ubi8 image like https://github.com/openshift/origin/pull/26072/files#diff-2743afa0b07bbf4dd58d08076cb9e16b645182ba82e83f9cc8a5575c29bf7db2R1

plus there are a lot spots where he has switched imagestreamtag refs from ruby:2.7 to ruby:2.7-ubi8 .... that moves things to registry.redhat.io/ubi8/ruby-27:latest

I would be very surprised if registry.redhat.io/ubi8/ruby-27:latest worked and registry.access.redhat.com/ubi8/ruby-27:latest did not.

So assuming openshift/origin#26072 looks OK in the morning I say let's move forward with this.

But of course I'm fine waiting on feedback from @adambkaplan and @soltysh as well if they have any.

thanks @yselkowitz / @bparees

@yselkowitz
Copy link
Contributor Author

Getting the tests and this coordinated will take a bit more work.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2021
@soltysh
Copy link

soltysh commented Apr 14, 2021

@gabemontero @adambkaplan @soltysh giving you guys a heads up on this one, please let me know when you've confirmed these changes are safe for your tests.

Similarly to what Gabe wrote earlier, from oc pov, most of the tests don't care about contents, as long as the image is present.

@bparees
Copy link
Contributor

bparees commented Apr 29, 2021

@yselkowitz are you still working on this? anything you need from us here or on openshift/origin#26072 ?

@yselkowitz
Copy link
Contributor Author

I am working on this (among many other things), but it looks like the origin PR can't be as self-isolated as I hoped, so it's going to take a bit longer to get a reviewable set of commits there.

@openshift-ci
Copy link

openshift-ci bot commented May 1, 2021

@yselkowitz: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2021
@yselkowitz
Copy link
Contributor Author

What is needed to get this in now?

@bparees
Copy link
Contributor

bparees commented Jun 14, 2021

@yselkowitz it's a manual merge process (i can do it) so if all the vetting has been done that these changes are compatible w/ origin testing, i can do it. let me know.

@gabemontero
Copy link

also needs to rebase per the git bot ...i.e. has needs-rebase label

@yselkowitz
Copy link
Contributor Author

Just tested a manual Dockerfile build of this with ruby-27-centos7 but w/o the explicit scl enable commands, and the container builds and runs like that, so it seems the container-entrypoint is doing its job, and this should be backwards compatible.

I rebased almost three weeks ago and there have been no new changes since; is the bot sleeping here?
/refresh

@bparees
Copy link
Contributor

bparees commented Jun 14, 2021

might be due to the hold
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@yselkowitz
Copy link
Contributor Author

/refresh

@bparees
Copy link
Contributor

bparees commented Jun 15, 2021

[shrug]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments