Bug 1949153: Use centos/ruby-27-centos7 by dulek · Pull Request #26070 · openshift/origin

dulek · 2021-04-13T14:45:01Z

As the openshift/ruby-hello-world was updated to Ruby 2.7 a ton of tests
keep failing. This commit replaces references to ruby-25-centos7 with
ruby-27-centos7.

openshift-ci-robot · 2021-04-13T14:45:03Z

@dulek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Use centos/ruby-27-centos7 in test-docker-no-outputname.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-13T14:49:22Z

@dulek: This pull request references Bugzilla bug 1949153, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (3.11.z) matches configured target release for branch (3.11.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1949153: Use centos/ruby-27-centos7 in test-docker-no-outputname.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-13T15:45:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dulek
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-04-14T08:50:38Z

@dulek: This pull request references Bugzilla bug 1949153, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (3.11.z) matches configured target release for branch (3.11.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1949153: Use centos/ruby-27-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2021-04-15T14:31:13Z

/retest

dulek · 2021-04-15T15:45:44Z

/test e2e-gcp

mtnbikenc · 2021-04-19T16:56:07Z

ipaddress package issue should be resolved by openshift/openshift-ansible#12326

dulek · 2021-04-20T10:01:15Z

/retest

dulek · 2021-04-21T09:42:32Z

/retest

Let's see if Jenkins jobs are fixed?

dulek · 2021-04-21T14:01:35Z

/retest

dulek · 2021-04-21T16:20:40Z

/retest

Okay, so what's failing now is still related to ruby app - looks like one test is wrongly looking for latest in the imagestream and others are hitting DockerHub pull limits. :/

mtnbikenc · 2021-04-21T17:01:04Z

The Ansible failure in e2e-gcp should be fixed by openshift/openshift-ansible@cf96965 when that PR merges. I noticed that the e2e-gcp test is not exiting when Ansible fails and the job will just time out. Must need some traps in that template.

mtnbikenc · 2021-04-22T14:15:14Z

openshift/openshift-ansible#12326 is merged.
/retest

mtnbikenc · 2021-04-22T15:59:01Z

e2e-gcp passed. 🎉

dulek · 2021-04-23T09:34:39Z

@mtnbikenc: I created openshift/ruby-hello-world#127 to fight the failures caused by DockerHub pull limits.

cc @bparees

As the openshift/ruby-hello-world was updated to Ruby 2.7 a ton of tests keep failing. This commit replaces references to ruby-25-centos7 with ruby-27-centos7.

dulek · 2021-04-30T13:49:50Z

/retest

dulek · 2021-05-04T09:58:52Z

/retest

Those errors are different than previously. :/

openshift-ci · 2021-05-04T10:48:42Z

@dulek: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_image_ecosystem	`c4f10ec`	link	`/test extended_image_ecosystem`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dulek · 2021-05-04T15:38:11Z

@bparees, @mfojtik: Seems like there are new problems with those two openshift-jenkins jobs. Can we consider overriding them as this unblocks e2e job allowing to merge openshift/openshift-ansible#12316?

bparees · 2021-05-04T15:42:01Z

/override ci/openshift-jenkins/cmd

openshift-ci-robot · 2021-05-04T15:42:06Z

@bparees: Overrode contexts on behalf of bparees: ci/openshift-jenkins/cmd

Details

In response to this:

/override ci/openshift-jenkins/cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-05-04T15:42:12Z

/override ci/openshift-jenkins/extended_clusterup

openshift-ci-robot · 2021-05-04T15:42:17Z

@bparees: Overrode contexts on behalf of bparees: ci/openshift-jenkins/extended_clusterup

Details

In response to this:

/override ci/openshift-jenkins/extended_clusterup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2021-05-07T11:42:41Z

@bparees, @mfojtik: Well, seems like it only requires /lgtm and /approve. Would you consider reviewing it given this is unblocking at least e2e-gcp job?

bparees · 2021-05-07T13:41:22Z

/lgtm

it also needs a cherry pick approval. i'm not sure how we're handling 3.11 merges in terms of cherry picks. I assume we're good to merge whenever, but maybe @brenton or @vikaslaad can confirm.

openshift-ci · 2021-05-07T13:41:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~examples/sample-app/OWNERS~~ [bparees]
~~pkg/oc/OWNERS~~ [bparees]
~~test/cmd/OWNERS~~ [bparees]
~~test/end-to-end/OWNERS~~ [bparees]
~~test/extended/OWNERS~~ [bparees]
~~test/integration/OWNERS~~ [bparees]
~~test/old-start-configs/OWNERS~~ [bparees]
~~test/testdata/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtnbikenc · 2021-05-12T13:56:45Z

Needs openshift/release#18516 to fix cherry-pick-approved requirement.

bparees · 2021-05-12T13:59:50Z

Needs openshift/release#18516 to fix cherry-pick-approved requirement.

since the label isn't supposed to be required anyway, i've just added it for now to bypass the requirement.

openshift-ci · 2021-05-12T13:59:51Z

@dulek: All pull requests linked via external trackers have merged:

openshift/origin#26070

Bugzilla bug 1949153 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1949153: Use centos/ruby-27-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xiuwang · 2021-06-02T06:33:56Z

examples/sample-app/application-template-dockerbuild.json

            "from": {
              "kind": "DockerImage",
-              "name": "docker.io/centos/ruby-25-centos7:latest"
+              "name": "docker.io/centos/ruby-27-centos7:latest"


Due to docker hub pull limit, we may use quay.io image quay.io/centos7/ruby-27-centos7

xiuwang · 2021-06-02T06:38:05Z

examples/sample-app/application-template-pullspecbuild.json

      },
      "spec": {
-        "dockerImageRepository": "centos/ruby-25-centos7"
+        "dockerImageRepository": "centos/ruby-27-centos7"


xiuwang · 2021-06-02T06:40:59Z

How about using quay.io image quay.io/centos7/ruby-27-centos7 to replace ruby-25-centos?

openshift-ci-robot requested review from bparees and mfojtik April 13, 2021 14:45

dulek changed the title ~~Use centos/ruby-27-centos7 in test-docker-no-outputname.json~~ Bug 1949153: Use centos/ruby-27-centos7 in test-docker-no-outputname.json Apr 13, 2021

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 13, 2021

dulek force-pushed the fix-3.11-tests branch 2 times, most recently from c4f10ec to 94d2a99 Compare April 13, 2021 15:44

dulek force-pushed the fix-3.11-tests branch from 94d2a99 to 46afb07 Compare April 14, 2021 07:40

dulek changed the title ~~Bug 1949153: Use centos/ruby-27-centos7 in test-docker-no-outputname.json~~ Bug 1949153: Use centos/ruby-27-centos7 Apr 14, 2021

mtnbikenc mentioned this pull request Apr 19, 2021

release-3.11: Fix pip dependencies in Dockerfile openshift/openshift-ansible#12324

Merged

mtnbikenc mentioned this pull request Apr 20, 2021

release-3.11: Revert code to address issue with missing python-ipaddress module openshift/openshift-ansible#12326

Merged

mtnbikenc mentioned this pull request Apr 22, 2021

Bug 1939605: cri-o+kuryr: Switch to proper netns management … openshift/openshift-ansible#12316

Merged

mtnbikenc mentioned this pull request Apr 27, 2021

[KIECLOUD-494] - Update RHPAM and RHDM templates and imagestreams on … openshift/openshift-ansible#12317

Merged

Use centos/ruby-27-centos7

a3cfd7f

As the openshift/ruby-hello-world was updated to Ruby 2.7 a ton of tests keep failing. This commit replaces references to ruby-25-centos7 with ruby-27-centos7.

dulek force-pushed the fix-3.11-tests branch from 46afb07 to a3cfd7f Compare April 29, 2021 09:54

dulek mentioned this pull request Apr 30, 2021

Switch base image registry to quay.io openshift/ruby-hello-world#127

Merged

openshift-ci bot assigned bparees May 7, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 12, 2021

openshift-merge-robot merged commit 03d38d3 into openshift:release-3.11 May 12, 2021

xiuwang reviewed Jun 2, 2021

View reviewed changes

Comments

Conversation

dulek commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 14, 2021

Uh oh!

dulek commented Apr 15, 2021

Uh oh!

dulek commented Apr 15, 2021

Uh oh!

mtnbikenc commented Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulek commented Apr 20, 2021

Uh oh!

dulek commented Apr 21, 2021

Uh oh!

dulek commented Apr 21, 2021

Uh oh!

dulek commented Apr 21, 2021

Uh oh!

mtnbikenc commented Apr 21, 2021

Uh oh!

mtnbikenc commented Apr 22, 2021

Uh oh!

mtnbikenc commented Apr 22, 2021

Uh oh!

dulek commented Apr 23, 2021

Uh oh!

dulek commented Apr 30, 2021

Uh oh!

dulek commented May 4, 2021

Uh oh!

openshift-ci bot commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dulek commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented May 4, 2021

Uh oh!

openshift-ci-robot commented May 4, 2021

Uh oh!

bparees commented May 4, 2021

Uh oh!

openshift-ci-robot commented May 4, 2021

Uh oh!

dulek commented May 7, 2021

Uh oh!

bparees commented May 7, 2021

Uh oh!

openshift-ci bot commented May 7, 2021

Uh oh!

mtnbikenc commented May 12, 2021

Uh oh!

bparees commented May 12, 2021

Uh oh!

openshift-ci bot commented May 12, 2021

Uh oh!

xiuwang Jun 2, 2021

Choose a reason for hiding this comment

Uh oh!

xiuwang Jun 2, 2021

Choose a reason for hiding this comment

Uh oh!

xiuwang commented Jun 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

dulek commented Apr 13, 2021 •

edited

Loading

mtnbikenc commented Apr 19, 2021 •

edited

Loading

openshift-ci bot commented May 4, 2021 •

edited

Loading

dulek commented May 4, 2021 •

edited

Loading