Skip to content

Comments

Update ruby-hello-world images#26250

Merged
mfojtik merged 2 commits intoopenshift:release-3.11from
soltysh:fix_units
Jun 21, 2021
Merged

Update ruby-hello-world images#26250
mfojtik merged 2 commits intoopenshift:release-3.11from
soltysh:fix_units

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 18, 2021

React to changes from openshift/ruby-hello-world#125

/assign @mfojtik

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@soltysh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Update ruby-hello-world images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link

aojea commented Jun 18, 2021

/cc

@openshift-ci openshift-ci bot requested a review from aojea June 18, 2021 14:36
@aojea
Copy link

aojea commented Jun 19, 2021

/lgtm
not familiar with the code but the tests now pass, and these only change the failing tests

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea, soltysh
To complete the pull request process, please ask for approval from mfojtik after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nee1esh
Copy link

nee1esh commented Jun 19, 2021

/retest

@sttts
Copy link
Contributor

sttts commented Jun 21, 2021

/override ci/openshift-jenkins/cmd
/override ci/openshift-jenkins/extended_clusterup

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@sttts: sttts unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

/override ci/openshift-jenkins/cmd
/override ci/openshift-jenkins/extended_clusterup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2021

/override ci/openshift-jenkins/cmd
/override ci/openshift-jenkins/extended_clusterup

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2021

/approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@mfojtik: Overrode contexts on behalf of mfojtik: ci/openshift-jenkins/cmd, ci/openshift-jenkins/extended_clusterup

Details

In response to this:

/override ci/openshift-jenkins/cmd
/override ci/openshift-jenkins/extended_clusterup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit 78a529c into openshift:release-3.11 Jun 21, 2021
@mfojtik mfojtik deleted the fix_units branch June 21, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants