AGENT-1429: Add ha5 dualstack job for ISO No Registry - #78986
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @andfasano @sadasu |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdate CI: change an existing agent job cron from 12-hourly to 8-hourly, add two new agent conformance jobs to the 5.0 nightly config, and insert an additional compact-ipv4 validation step into the agent conformance ISO-no-registry workflow. ChangesAgent CI: workflow + nightly job updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/depends on openshift-metal3/dev-scripts#1884 |
7ca34ac to
2844004
Compare
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold cancel |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
2844004 to
bd7eb7b
Compare
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml`:
- Line 11: The generic workflow includes a topology/network-specific step ref
"agent-e2e-compact-ipv4-iso-no-registry-validation" which causes non-compact or
non-IPv4 jobs to fail; remove this hard-coded ref from the shared workflow
(agent-e2e-generic-conformance-iso-no-registry-workflow.yaml) and either (a)
move the "agent-e2e-compact-ipv4-iso-no-registry-validation" step into
compact-IPv4-specific jobs/workflows, or (b) replace it with a topology-agnostic
validation step or a conditional/parameterized reference so only compact IPv4
jobs invoke that validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 95ae43f9-e016-49ee-a7e1-2f0334a99b30
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yamlci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yamlci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yamlci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
✅ Files skipped from review due to trivial changes (1)
- ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
🚧 Files skipped from review as they are similar to previous changes (2)
- ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
- ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
2 similar comments
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
|
/pj-rehearse |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/approve |
|
/lgtm |
|
/assign @neisw |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, pawanpinjarkar, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e12a44b
into
openshift:main
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
This adds the iso-no-registry tests for 4.22 that were removed in #78986.
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.
6 participants
e2e-agent-ha5-dualstack-iso-no-registry-techpreview