AGENT-1556: Add iso-no-registry tests to 4.22 by bfournie · Pull Request #82087 · openshift/release

bfournie · 2026-07-17T14:55:30Z

This adds the iso-no-registry tests for 4.22 that were removed in #78986.

Summary by CodeRabbit

Restores OpenShift 4.22 agent ISO no-registry conformance coverage in the nightly Prow configuration. It adds four scheduled tests on equinix-ocp-metal:

Compact IPv4
HA dual-stack
Five-control-plane dual-stack
SNO IPv4

Each test uses the ISO no-registry workflow, ISO boot mode, builder-cache cleanup, and TechPreviewNoUpgrade. The five-control-plane test adds a 150-minute setup timeout. The SNO test targets amd64 and sets AGENT_PLATFORM_TYPE=none.

openshift-ci-robot · 2026-07-17T14:55:34Z

@bfournie: This pull request references AGENT-1556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This adds the iso-no-registry tests for 4.22 that were removed in #78986.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-17T14:56:09Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f276598a-25bb-4301-85b5-11252d460876

📥 Commits

Reviewing files that changed from the base of the PR and between 40e69a8 and 9979ea4.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

Walkthrough

Adds four scheduled agent ISO no-registry conformance jobs to the nightly 4.22 release configuration. The jobs cover compact IPv4, HA dual-stack, five-control-plane dual-stack, and SNO IPv4 scenarios.

Changes

Agent ISO conformance

Layer / File(s)	Summary
Configure scheduled ISO conformance jobs `ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml`	Adds four `equinix-ocp-metal` jobs with distinct cron schedules. Each job uses ISO boot, builder-cache cleanup, and `TechPreviewNoUpgrade`. The five-control-plane job sets a 150-minute setup timeout. The SNO job targets `amd64` and sets `AGENT_PLATFORM_TYPE=none`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: lgtm, approved

Suggested reviewers: neisw, xueqzhan

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	The repository inspection tool failed to initialize, so the changed files could not be verified.	Retry repository inspection to confirm whether the pull request changes any Ginkgo test code.
Container-Privileges	❓ Inconclusive	Repository inspection could not run because the shell tool connection failed repeatedly.	Retry repository inspection to verify whether the added YAML jobs contain privileged settings.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding ISO no-registry tests for the 4.22 release.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The change adds four static CI test job definitions; it does not add or alter Ginkgo It(), Describe(), Context(), or When() titles.
Microshift Test Compatibility	✅ Passed	The pull request adds only CI YAML jobs and no new Ginkgo e2e tests, so the MicroShift Test Compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only a CI YAML file and adds no Ginkgo e2e tests, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change adds only CI release-job YAML entries; it does not add or modify deployment manifests, operator code, controllers, or workload scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The pull request changes only CI YAML job declarations and adds no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds only four CI YAML job definitions; it adds no Ginkgo test code, IPv4 literals, or external connectivity logic to assess.
No-Weak-Crypto	✅ Passed	The pull request adds only CI YAML job declarations and contains no cryptographic algorithms, custom crypto, or secret comparisons.
No-Sensitive-Data-In-Logs	✅ Passed	The changes add CI YAML test configurations only; they do not add logging statements or expose passwords, tokens, PII, hostnames, session IDs, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

andfasano · 2026-07-17T17:18:28Z

/lgtm

bfournie · 2026-07-17T17:39:57Z

/pj-rehearse

openshift-merge-bot · 2026-07-17T17:41:38Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-17T17:52:18Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

openshift-merge-bot · 2026-07-17T17:56:22Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-17T19:03:12Z

/pj-rehearse ack

openshift-merge-bot · 2026-07-17T19:03:46Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

andfasano · 2026-07-22T16:02:15Z

        WORKER_MEMORY=24576
      TEST_SUITE: openshift/conformance/parallel
    workflow: agent-e2e-generic-conformance
+- as: e2e-agent-compact-iso-no-registry


@sadasu just as a double check, will your recent change to the verify-promotion-feature job work by branch, isn't it?

bfournie · 2026-07-31T11:04:28Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha-dualstack-iso-no-registry

openshift-merge-bot · 2026-07-31T11:04:30Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-31T11:04:47Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry

openshift-merge-bot · 2026-07-31T11:04:50Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-31T14:39:01Z

Tests are failing because updated mco image is not in a nightly yet. Will retest when this is available in nightly.

bfournie · 2026-08-03T20:38:32Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

openshift-merge-bot · 2026-08-03T20:38:35Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-08-03T20:39:03Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry

openshift-merge-bot · 2026-08-05T10:57:07Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

coderabbitai · 2026-08-06T10:53:48Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

bfournie · 2026-08-06T10:57:15Z

/pj-rehearse

openshift-merge-bot · 2026-08-06T10:57:18Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

coderabbitai · 2026-08-06T12:10:41Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

bfournie · 2026-08-06T12:11:30Z

/pj-rehearse

openshift-merge-bot · 2026-08-06T12:11:33Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-08-06T12:14:02Z

[REHEARSALNOTIFIER]
@bfournie: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-sno-ipv4-iso-no-registry	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha-dualstack-iso-no-registry	N/A	periodic	Periodic changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

bfournie · 2026-08-06T18:36:59Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-06T18:37:02Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pawanpinjarkar · 2026-08-06T18:58:39Z

/lgtm

pawanpinjarkar · 2026-08-06T18:58:51Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

openshift-merge-bot · 2026-08-06T18:58:54Z

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

deepsm007 · 2026-08-06T19:58:37Z

/approve

openshift-ci · 2026-08-06T19:59:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie, deepsm007, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/release/OWNERS~~ [deepsm007]
~~ci-operator/jobs/openshift/release/OWNERS~~ [deepsm007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026

openshift-ci Bot requested review from neisw and xueqzhan July 17, 2026 14:58

andfasano reviewed Jul 17, 2026

View reviewed changes

Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated

bfournie force-pushed the agent-iso-no-registry-4.22 branch from d111de9 to c476c18 Compare July 17, 2026 15:12

andfasano reviewed Jul 17, 2026

View reviewed changes

Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated

bfournie force-pushed the agent-iso-no-registry-4.22 branch from c476c18 to 392314c Compare July 17, 2026 16:19

openshift-ci Bot assigned andfasano Jul 17, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2026

andfasano reviewed Jul 22, 2026

View reviewed changes

bfournie force-pushed the agent-iso-no-registry-4.22 branch from 392314c to f7f9b17 Compare August 3, 2026 20:37

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026

pawanpinjarkar reviewed Aug 5, 2026

View reviewed changes

Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated

bfournie force-pushed the agent-iso-no-registry-4.22 branch from f7f9b17 to c1836a8 Compare August 6, 2026 10:53

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026

AGENT-1556: Add iso-no-registry tests to 4.22

9979ea4

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

bfournie force-pushed the agent-iso-no-registry-4.22 branch from c1836a8 to 9979ea4 Compare August 6, 2026 12:10

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 6, 2026

openshift-ci Bot assigned pawanpinjarkar Aug 6, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026

openshift-merge-bot Bot merged commit 544968a into openshift:main Aug 6, 2026
5 of 20 checks passed

bfournie deleted the agent-iso-no-registry-4.22 branch August 6, 2026 20:12

TimurMP pushed a commit to TimurMP/release that referenced this pull request Aug 9, 2026

AGENT-1556: Add iso-no-registry tests to 4.22 (openshift#82087)

68f04c5

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

jzding pushed a commit to jzding/release that referenced this pull request Aug 11, 2026

AGENT-1556: Add iso-no-registry tests to 4.22 (openshift#82087)

f8a4771

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

davdhacs pushed a commit to davdhacs/release that referenced this pull request Aug 12, 2026

AGENT-1556: Add iso-no-registry tests to 4.22 (openshift#82087)

b6d7028

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026

AGENT-1556: Add iso-no-registry tests to 4.22 (openshift#82087)

0cf044c

This adds the iso-no-registry tests for 4.22 that were removed in openshift#78986.

Uh oh!

Conversation

bfournie commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 17, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (2 inconclusive)

Uh oh!

Uh oh!

Uh oh!

andfasano commented Jul 17, 2026

Uh oh!

bfournie commented Jul 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 17, 2026

Uh oh!

bfournie commented Jul 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 17, 2026

Uh oh!

bfournie commented Jul 17, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 17, 2026

Uh oh!

andfasano Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

bfournie commented Jul 31, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 31, 2026

Uh oh!

bfournie commented Jul 31, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 31, 2026

Uh oh!

bfournie commented Jul 31, 2026

Uh oh!

bfournie commented Aug 3, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 3, 2026

Uh oh!

bfournie commented Aug 3, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

bfournie commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026

Uh oh!

bfournie commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

bfournie commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

pawanpinjarkar commented Aug 6, 2026

Uh oh!

pawanpinjarkar commented Aug 6, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 6, 2026

Uh oh!

deepsm007 commented Aug 6, 2026

bfournie commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 17, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading