Skip to content

Rename VSphere UPI job to e2e-vsphere-upi. #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 25, 2020
Merged

Rename VSphere UPI job to e2e-vsphere-upi. #7560

openshift-merge-robot merged 1 commit into from
Mar 25, 2020

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Mar 10, 2020 •
edited
Loading

VSphere IPI is in progress at #7470. Having this change would make testing rehearsals a little easier because in certain scenarios (i.e. the current one where I am using the e2e upi template for the ipi install) only the upi rehearsal will be triggered for the ipi PR.

According to the naming convention, the VSphere UPI job should be e2e-vsphere-upi. The current name is e2e-vsphere which should be the ipi job. Making this change will make room for the ipi job.

This commit was generated by changing e2e-vsphere to e2e-vsphere-upi in ci-operator/config/openshift/installer/openshift-installer-master.yaml then running:

docker run -it -v $(pwd)/ci-operator:/ci-operator:z           \
  registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest \
  --from-dir /ci-operator/config/ --to-dir /ci-operator/jobs

cc @jcpowermac

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2020
@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2020
@patrickdillon patrickdillon mentioned this pull request Mar 23, 2020
Merged
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 23, 2020

/hold until #7586 merges then we can rename both jobs at once

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 25, 2020
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 25, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@patrickdillon
Rename vSphere UPI and IPI jobs.
569a713 
Based on convention rename e2e-vsphere -> e2e-vsphere-upi and e2e-vsphere-steps -> e2e-vsphere. Maintains always_run: false and optional: true.

This commit was generated by changing e2e-vsphere to e2e-vsphere-upi in ci-operator/config/openshift/installer/openshift-installer-master.yaml then running:

docker run -it -v $(pwd)/ci-operator:/ci-operator:z           \
  registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest \
  --from-dir /ci-operator/config/ --to-dir /ci-operator/jobs
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere-upi 569a713 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere 569a713 link /test pj-rehearse
ci/prow/pj-rehearse 569a713 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Mar 25, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jcpowermac, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 23af5b9 into openshift:master Mar 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2020

@patrickdillon: Updated the following 7 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
Details

In response to this:

VSphere IPI is in progress at #7470. Having this change would make testing rehearsals a little easier because in certain scenarios (i.e. the current one where I am using the e2e upi template for the ipi install) only the upi rehearsal will be triggered for the ipi PR.

According to the naming convention, the VSphere UPI job should be e2e-vsphere-upi. The current name is e2e-vsphere which should be the ipi job. Making this change will make room for the ipi job.

This commit was generated by changing e2e-vsphere to e2e-vsphere-upi in ci-operator/config/openshift/installer/openshift-installer-master.yaml then running:

docker run -it -v $(pwd)/ci-operator:/ci-operator:z           \
 registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest \
 --from-dir /ci-operator/config/ --to-dir /ci-operator/jobs

cc @jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrickdillon @jcpowermac @openshift-ci-robot @abhinavdahiya @openshift-merge-robot