Add VSphere IPI e2e steps #7586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
5 times, most recently
from
35441f6 to
0ac8acf
Compare
openshift-ci-robot
added
the
do-not-merge/invalid-owners-file
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
from
0ac8acf to
65f5a97
Compare
openshift-ci-robot
removed
the
do-not-merge/invalid-owners-file
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
5 times, most recently
from
30d71aa to
ee10718
Compare
Contributor
Author
|
/test pj-rehearse |
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
3 times, most recently
from
5c6d1ec to
e0fa706
Compare
Contributor
Author
|
/test pj-rehearse |
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
7 times, most recently
from
19f52bd to
4a71175
Compare
openshift-ci-robot
added
the
needs-rebase
wking
reviewed
Mar 23, 2020
ci-operator/step-registry/ipi/conf/vsphere/dns/ipi-conf-vsphere-dns-commands.sh
Outdated
Show resolved
Hide resolved
wking
reviewed
Mar 23, 2020
Member
There was a problem hiding this comment.
I'd rather extract this from a mounted secret (/var/run/secrets/...), instead of hard-coding it in two separate steps.
Contributor
Author
There was a problem hiding this comment.
What about a BASE_DOMAIN envvar set in the job?
wking
reviewed
Mar 23, 2020
ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
should be move towards openshift/installer#3292 ?
ci-operator/step-registry/ipi/conf/vsphere/dns/ipi-conf-vsphere-dns-ref.yaml
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/ipi/conf/vsphere/ipi-conf-vsphere-chain.yaml
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/ipi/conf/vsphere/vips/ipi-conf-vsphere-vips-ref.yaml
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/origin/e2e/vsphere/origin-e2e-vsphere-workflow.yaml
Outdated
Show resolved
Hide resolved
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
6 times, most recently
from
9579306 to
aaecbc2
Compare
Contributor
Author
|
/test pj-rehearse |
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
3 times, most recently
from
83d17b9 to
33e99dc
Compare
- pre steps: reserve IPS set up DNS records in route53 write install-config - install/test: install using upi image in order to include CA cert test - teardown cluster teardown release vips delete DNS records
Note that this job is currently named e2e-vsphere-steps. The intention is to name it e2e-vsphere, which is currently the name of the upi job. Renaming this job and the upi job will be handled in a separate commit.
patrickdillon
force-pushed
the
vsphere-ipi-steps
branch
from
33e99dc to
9883317
Compare
Contributor
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@patrickdillon: Updated the following 9 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 5, 2021
The ref was born in fa871a1 (Add VSphere IPI e2e steps, 2020-03-23, openshift#7586) so it could use the upi-installer image to work with a self-signed certificate. But vSphere installation hasn't required that since fe3ea6a (vSphere: remove the use of upi-installer image; which will prepare for upgrade testing, 2020-10-12, openshift#12725). Remove the vSphere-specific step and point consumers at the generic step instead. Same for the deprovision step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vSphere IPI e2e tests. Depends on openshift/installer#3327.
Also related is #7560. This could be merged first and #7560 updated.
Updates installer presubmit job