Skip to content

WIP: Add VSphere IPI to e2e template. #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrickdillon wants to merge 1 commit into from
Closed

WIP: Add VSphere IPI to e2e template. #7470

patrickdillon wants to merge 1 commit into from

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Mar 4, 2020

Adds VSphere IPI as an option for e2e template:

  • template reserves virtual IPs required for vsphere install
  • teardown removes virtual IPs
  • update installer presubmit job
  • rename upi job in installer repo to have -upi postfix, following upi convention.

This is WIP. I'm hoping rehearsals will be a good way to test this.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 4, 2020

Looks good though we don't vsphere ipi working yet :)

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 4, 2020

Looks good though we don't vsphere ipi working yet :)

Test-driven development, baaaaaaaaaby!

patrickdillon
patrickdillon commented Mar 4, 2020
View reviewed changes
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml Outdated
Copy link
Contributor Author

@patrickdillon patrickdillon Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcpowermac do you think this is the right value for network?

Copy link
Contributor

@jcpowermac jcpowermac Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

https://github.com/openshift/installer/blob/58ecac34ae25797f62fb10504982a8b4562fdaf7/upi/vsphere/machine/ip.tf#L31

And

release/ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

Line 1777 in bd3adfe

machine_cidr = "139.178.87.128/25"

Copy link
Contributor Author

@patrickdillon patrickdillon Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better? I think I was thrown by this: https://github.com/openshift/installer/blob/master/upi/vsphere/machine/cidr_to_ip.sh#L6

Copy link
Contributor

@jcpowermac jcpowermac Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs just to be the ip based on:

https://github.com/openshift/installer/blob/58ecac34ae25797f62fb10504982a8b4562fdaf7/upi/vsphere/machine/ip.tf#L2
https://www.terraform.io/docs/configuration/functions/cidrhost.html

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 2 times, most recently from dcca2c3 to ebd1578 Compare March 4, 2020 21:29
abhinavdahiya
abhinavdahiya reviewed Mar 4, 2020
View reviewed changes
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml Outdated
Comment on lines 658 to 607
Copy link
Contributor

@abhinavdahiya abhinavdahiya Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm..

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 5, 2020

/test pj-rehearse

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 2 times, most recently from 2f75060 to 8d2e5dd Compare March 5, 2020 15:33
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 5, 2020

/test pj-rehearse

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 2 times, most recently from cdce1bb to 440728a Compare March 5, 2020 19:03
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 5, 2020

/test pj-rehearse

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 2 times, most recently from ab320ec to f1c9df6 Compare March 6, 2020 14:44
@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 6, 2020

@patrickdillon I just remembered something. A records for api and *.apps wildcard.
That will needed to be added somewhere. Could use dnsmasq or /shrug just add to hosts file though I am not sure that will work for wildcard

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 7 times, most recently from 86c9e32 to 29a6fd6 Compare March 10, 2020 13:43
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 10, 2020

VSphere IPI has dependencies on jq as it utilizes cider_to_ip.sh to reserve ip addresses and whatever tool we use for dns records--I am thinking awscli for route53.

I am struggling to install dependencies in the installer image used in the normal e2e ipi template. The user is non-root and I ran into permissions issues trying to install yum packages or downloading and unzipping binaries. I tried installing with pip, but the image does not have a recognized C compiler.

I am now playing with moving the VSphere IPI to the UPI template as it has all of the necessary dependencies.

@patrickdillon patrickdillon force-pushed the vsphere-ipi branch 5 times, most recently from 17522ac to 3b2c22e Compare March 10, 2020 16:13
@patrickdillon patrickdillon mentioned this pull request Mar 10, 2020
Merged
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 10, 2020

/test pj-rehearse

@patrickdillon
Add VSphere IPI to e2e template.
1169f0a 
Adds VSphere IPI as an option for e2e template:
- template reserves virtual IPs required for vsphere install
- teardown removes virtual IPs
- update installer presubmit job
- rename upi job in installer repo to have -upi postfix, following upi convention.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2020

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/cri-o/cri-o/release-1.13/e2e-aws 86c9e3258d3cb6ffc8e28e2b63ab114a26a0316f link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-azure 86c9e3258d3cb6ffc8e28e2b63ab114a26a0316f link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere d5c0f54b821af34c727369c3654b8f838931755a link /test pj-rehearse
ci/prow/generated-config 1169f0a link /test generated-config
ci/rehearse/openshift/installer/master/e2e-vsphere-ipi 1169f0a link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azure-upi 1169f0a link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere-upi 1169f0a link /test pj-rehearse
ci/prow/pj-rehearse 1169f0a link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 21, 2020

@patrickdillon: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2020
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Mar 23, 2020 •
edited
Loading

/close
in favor of #7586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patrickdillon @openshift-ci-robot @jcpowermac @abhinavdahiya