-
Notifications
You must be signed in to change notification settings - Fork 2.1k
OSASINFRA-3960: Rework e2e-techpreview job for CAPO #72179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSASINFRA-3960: Rework e2e-techpreview job for CAPO #72179
Conversation
|
@stephenfin: This pull request references OSASINFRA-3960 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Start calling the script directly to allow us to remove the otherwise useless Makefile target. Also rename the job to e2e-openstack-capi-techpreview to better capture its intent and align with CAPI providers. Signed-off-by: Stephen Finucane <[email protected]>
f238c3e to
0b728d6
Compare
|
/hold We need to merge openshift/cluster-api-provider-openstack#385 first |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold remove openshift/cluster-api-provider-openstack#385 is merged now so no need for the hold. We can ack the rehearsal once it comes back. |
These are remnants of the in-tree infracluster controller and are no longer used by CI jobs [1][2]. [1] openshift/release#72179 [2] openshift/release#72221 Signed-off-by: Stephen Finucane <[email protected]>
|
I think the failure is happening because our |
|
openshift/cluster-api-provider-openstack#388 should fix this. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/unhold |
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Start calling the script directly to allow us to remove the otherwise useless Makefile target. Also rename the job to e2e-openstack-capi-techpreview to better capture its intent and align with CAPI providers. Signed-off-by: Stephen Finucane <[email protected]>
Start calling the script directly to allow us to remove the otherwise useless Makefile target. Also rename the job to e2e-openstack-capi-techpreview to better capture its intent and align with CAPI providers.