Skip to content

Conversation

@stephenfin
Copy link
Contributor

Start calling the script directly to allow us to remove the otherwise useless Makefile target. Also rename the job to e2e-openstack-capi-techpreview to better capture its intent and align with CAPI providers.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2025

@stephenfin: This pull request references OSASINFRA-3960 which is a valid jira issue.

Details

In response to this:

Start calling the script directly to allow us to remove the otherwise useless Makefile target. Also rename the job to e2e-openstack-capi-techpreview to better capture its intent and align with CAPI providers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Start calling the script directly to allow us to remove the otherwise
useless Makefile target. Also rename the job to
e2e-openstack-capi-techpreview to better capture its intent and align
with CAPI providers.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin force-pushed the migrate-openstack-infracluster-controller branch from f238c3e to 0b728d6 Compare December 4, 2025 18:06
@stephenfin
Copy link
Contributor Author

/hold

We need to merge openshift/cluster-api-provider-openstack#385 first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.22-e2e-openstack-capi-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.22-e2e-openstack-capi-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stephenfin
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview

@openshift-ci-robot
Copy link
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stephenfin
Copy link
Contributor Author

/hold remove

openshift/cluster-api-provider-openstack#385 is merged now so no need for the hold. We can ack the rehearsal once it comes back.

stephenfin added a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Dec 5, 2025
These are remnants of the in-tree infracluster controller and are no
longer used by CI jobs [1][2].

[1] openshift/release#72179
[2] openshift/release#72221

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
Copy link
Contributor Author

stephenfin commented Dec 5, 2025

I think the failure is happening because our openshift/e2e-tests.sh script in CAPO expects the branch name to be main - which is is for CAPO and CCAPIO - but it's master here. I did it that way because that's what CAPA had done but I imagine they're broken in the same way

@stephenfin
Copy link
Contributor Author

openshift/cluster-api-provider-openstack#388 should fix this.

@stephenfin
Copy link
Contributor Author

/retest

openshift/cluster-api-provider-openstack#388 is merged

@stephenfin
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-openstack-capi-techpreview

@openshift-ci-robot
Copy link
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stephenfin
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 5, 2025
@stephenfin
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 24430ab into openshift:master Dec 5, 2025
16 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the migrate-openstack-infracluster-controller branch December 5, 2025 18:55
dfrazzette pushed a commit to dfrazzette/release that referenced this pull request Dec 9, 2025
Start calling the script directly to allow us to remove the otherwise
useless Makefile target. Also rename the job to
e2e-openstack-capi-techpreview to better capture its intent and align
with CAPI providers.

Signed-off-by: Stephen Finucane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants