OSASINFRA-3960: Remove in-tree infracluster controller #385
Conversation
Since this is now handled in cluster-capi-operator. In this part, we remove the assets that deploy it. Signed-off-by: Stephen Finucane <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request references OSASINFRA-3960 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
stephenfin
force-pushed
the
migrate-openstack-infracluster-controller
branch
2 times, most recently
from
4606df7 to
9d94be0
Compare
Since this is now handled in cluster-capi-operator. In this part, we remove the controller itself which is no longer deployed. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
migrate-openstack-infracluster-controller
branch
from
9d94be0 to
9d76669
Compare
|
/test e2e-techpreview |
|
The hypershift job is not going to pass, it's known to fail ATM. We should have enough coverage with the e2e-techpreview job. |
|
/override ci/prow/e2e-hypershift |
|
@mandre: Overrode contexts on behalf of mandre: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
From the logs: We would have to update the job :) |
|
/override ci/prow/e2e-techpreview This job needs to be reworked, as @mandre says. The main change at openshift/cluster-capi-operator#411 has merged so lets get this in then go rework thing here to run the CCAPIO job here as a follow-up. |
|
@stephenfin: Overrode contexts on behalf of stephenfin: ci/prow/e2e-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label acknowledge-critical-fixes-only We need to get this in so we can bump CAPO to the latest upstream release as part of the OpenShift 4.21 release. |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
@stephenfin, I'll let you remove the hold when appropriate. We're still working on having CI on this change but I'm afraid we'll have to merge without any CI confirmation to meet the deadline tomorrow. The risk is low though, as both consumers of this code, CCAPIO and Hypershift are still tech preview. We expect to have successful CI runs very soon.
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
stephenfin
force-pushed
the
migrate-openstack-infracluster-controller
branch
from
7492bc4 to
e152d6a
Compare
I've re-added the |
|
/override ci/prow/e2e-hypershift We know it's broken. No point burning resources. |
|
@stephenfin: Overrode contexts on behalf of stephenfin: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-techpreview |
This aligns us with other platform's test strategies, e.g. [1][2][3]. We also temporarily re-add the e2e Makefile target to call this script. Once we have removed use of this target from the relevant CI jobs we can remove the target itself. [1] https://github.com/openshift/cluster-api-provider-aws/blob/47bf1f7464c4ae43ecf9d62e156f0795d8daab2f/openshift/e2e-tests.sh [2] https://github.com/openshift/cluster-api-provider-azure/blob/b7682c874dc67d46a8b430f841cf9cd2faaf184f/openshift/e2e-tests.sh [3] https://github.com/openshift/cluster-api-provider-gcp/blob/41bfe595bd316af726e1de18f3c32767cd7ac30f/openshift/e2e-tests.sh Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
migrate-openstack-infracluster-controller
branch
from
e152d6a to
a5baf7b
Compare
|
/test e2e-techpreview |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
We got a successful CCAPIO e2e test run
/lgtm
|
/override ci/prow/e2e-hypershift |
|
@mandre: Overrode contexts on behalf of mandre: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@mandre: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
deleted the
migrate-openstack-infracluster-controller
branch
3 participants
We are are moving this into cluster-capi-operator in openshift/cluster-capi-operator#411.