Skip to content

Conversation

@stephenfin
Copy link

PULL_BASE_REF will be set to master when running rehearsals since that is the default branch for openshift/release currently. Ensure we rewrite things appropriately.

See openshift/release#72179 for more context.

PULL_BASE_REF will be set to master when running rehearsals since that
is the default branch for openshift/release currently. Ensure we rewrite
things appropriately.

Signed-off-by: Stephen Finucane <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2025

@stephenfin: This pull request references OSASINFRA-3960 which is a valid jira issue.

Details

In response to this:

PULL_BASE_REF will be set to master when running rehearsals since that is the default branch for openshift/release currently. Ensure we rewrite things appropriately.

See openshift/release#72179 for more context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@stephenfin
Copy link
Author

/label acknowledge-critical-fixes-only
/verified by CI
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-techpreview

This is a no-op for this repo. No point burning CI time on it.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 5, 2025
@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 5, 2025
@openshift-ci-robot
Copy link

@stephenfin: This PR has been marked as verified by CI.

Details

In response to this:

/label acknowledge-critical-fixes-only
/verified by CI
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-techpreview

This is a no-op for this repo. No point burning CI time on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

@stephenfin: Overrode contexts on behalf of stephenfin: ci/prow/e2e-hypershift, ci/prow/e2e-techpreview

Details

In response to this:

/label acknowledge-critical-fixes-only
/verified by CI
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-techpreview

This is a no-op for this repo. No point burning CI time on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2d0f174 into openshift:main Dec 5, 2025
10 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix-rehearsals branch December 5, 2025 15:40
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants