Skip to content

d/s: update owners #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 17, 2024
Merged

d/s: update owners #964

openshift-merge-bot merged 1 commit into from
Jul 17, 2024

Conversation

@zeeke
Copy link
Contributor

@zeeke zeeke commented Jul 16, 2024

This might help with merging/reviewing downstream PR. e.g.

@zeeke
d/s: update owners
6f3471d 
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@openshift-ci openshift-ci bot requested review from SchSeba and fepan July 16, 2024 10:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor

SchSeba commented Jul 17, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 33edc06 into openshift:master Jul 17, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 17, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.17.0-202407171011.p0.g33edc06.assembly.stream.el9 for distgit sriov-network-operator.
All builds following this will include this PR.

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Nov 23, 2025
@SchSeba
Merge pull request openshift#964 from rollandf/disable-plugins-helm
9738ce4 
feat: support disable plugins via helm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fepan fepan Awaiting requested review from fepan

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees

@SchSeba SchSeba

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeeke @SchSeba @openshift-bot