Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ci-operator/config/coreos/rpm-ostree/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
approvers:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need reviewers so that we could LGTM PRs here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvers get used when no reviewers get listed

- miabbott
- cgwalters
- bgilbert
- dustymabe
- mike-nguyen
- jlebon
- zonggen
- ashcrow
- darkmuggle
- ajeddeloh
- lucab
- arithx
- vrutkovs
27 changes: 27 additions & 0 deletions ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
build_root:
image_stream_tag:
namespace: coreos
name: cosa-buildroot
tag: latest

# With this we build a container image derived from cosa-buildroot
# that contains new rpm-ostree binaries. From there...since this
# cluster doesn't support recursive containerization or virt,
# we can't do much interesting to test it today. But hopefully
# that will soon change.
# https://github.com/openshift/release/issues/4892
binary_build_commands: env SKIP_INSTALLDEPS=1 ./ci/build-check.sh

tests:
- as: sanity
commands: rpm-ostree --version
container:
from: bin

resources:
'*':
limits:
memory: 6Gi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of memory for your sanity test :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah, the build process (gcc and Rust compilers) is what uses RAM; could dial that back down some.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately I think what we really want is to

  1. Attribute resource usage to repositories and organizations and keep it sane
  2. https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler

requests:
cpu: 1000m
memory: 3Gi
14 changes: 14 additions & 0 deletions ci-operator/jobs/coreos/rpm-ostree/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
approvers:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need reviewers so that we could LGTM PRs here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't approvers also reviewers?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seems it works like this too

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you /lgtm this?

- miabbott
- cgwalters
- bgilbert
- dustymabe
- mike-nguyen
- jlebon
- zonggen
- ashcrow
- darkmuggle
- ajeddeloh
- lucab
- arithx
- vrutkovs
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
presubmits:
coreos/rpm-ostree:
- agent: kubernetes
always_run: true
branches:
- master
context: ci/prow/sanity
decorate: true
decoration_config:
skip_cloning: true
labels:
ci-operator.openshift.io/prowgen-controlled: "true"
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-coreos-rpm-ostree-master-sanity
rerun_command: /test sanity
spec:
containers:
- args:
- --artifact-dir=$(ARTIFACTS)
- --give-pr-author-access-to-namespace=true
- --sentry-dsn-path=/etc/sentry-dsn/ci-operator
- --target=sanity
command:
- ci-operator
env:
- name: CONFIG_SPEC
valueFrom:
configMapKeyRef:
key: coreos-rpm-ostree-master.yaml
name: ci-operator-master-configs
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/sentry-dsn
name: sentry-dsn
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: sentry-dsn
secret:
secretName: sentry-dsn
trigger: (?m)^/test( | .* )sanity,?($|\s.*)