Skip to content

Fix cli, cli-artifacts image generation for okd scos - #51533

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
Prashanth684:okd-cli
May 6, 2024
Merged

Fix cli, cli-artifacts image generation for okd scos#51533
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
Prashanth684:okd-cli

Conversation

@Prashanth684

@Prashanth684 Prashanth684 commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

In an effort to build OKD on top of centos stream(https://issues.redhat.com/browse/OKD-210), OKD-scos configs were added in #50118. We are going through all images and identifying the ones which do not build and are working to fix them. Changed the golang-builder to use 1.21.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@openshift-ci
openshift-ci Bot requested review from deads2k and mfojtik April 30, 2024 16:53
@Prashanth684

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-oc-master-okd-scos-images

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu

Copy link
Copy Markdown
Member

/test ci-operator-registry

@Prashanth684

Copy link
Copy Markdown
Contributor Author

/cc @LorbusChris

@openshift-ci
openshift-ci Bot requested a review from LorbusChris April 30, 2024 18:15
@LorbusChris

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@LorbusChris

Copy link
Copy Markdown
Contributor

/pj-rehearse ack
/assign @mfojtik

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@LorbusChris: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@Prashanth684 Prashanth684 changed the title WIP: fix cli, cli-artifacts image generation for okd scos Fix cli, cli-artifacts image generation for okd scos Apr 30, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
namespace: ocp
tag: rhel-9-golang-1.20-openshift-4.16
ocp_builder_rhel-9-golang-1.21-openshift-4.16:
name: builder

@Prashanth684 Prashanth684 Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jupierce is this something that needs to be corrected in the automation, i.e the generation of rhel9 golang-1.21 builder images

@Prashanth684

Copy link
Copy Markdown
Contributor Author

/cc @soltysh

@openshift-ci
openshift-ci Bot requested a review from soltysh May 1, 2024 21:17
from: cli
inputs:
ocp_builder_rhel-8-golang-1.20-openshift-4.16:
ocp_builder_rhel-8-golang-1.21-openshift-4.16:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to go 1.21 makes sense. However, we have switched to RHEL9 entirely openshift/oc#1752 and I think, this configuration files should be simplified by only having rhel9-1-21 builder and removing the rest. Something similar to #51610

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Prashanth684, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 6, 2024
In an effort to build OKD on top of centos stream(https://issues.redhat.com/browse/OKD-210), OKD-scos configs were added in openshift#50118. We are going through all images and identifying the ones which do not build and are working to fix them. Changed the golang-builder to use 1.21.
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prashanth684: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oc-master-okd-scos-images openshift/oc presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Prashanth684

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-oc-master-okd-scos-images

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ardaguclu

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-ci

openshift-ci Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, LorbusChris, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@Prashanth684

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 6, 2024
@openshift-ci

openshift-ci Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 25b3b76 into openshift:master May 6, 2024
acornett21 pushed a commit to acornett21/openshift-release that referenced this pull request May 8, 2024
In an effort to build OKD on top of centos stream(https://issues.redhat.com/browse/OKD-210), OKD-scos configs were added in openshift#50118. We are going through all images and identifying the ones which do not build and are working to fix them. Changed the golang-builder to use 1.21.
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
In an effort to build OKD on top of centos stream(https://issues.redhat.com/browse/OKD-210), OKD-scos configs were added in openshift#50118. We are going through all images and identifying the ones which do not build and are working to fix them. Changed the golang-builder to use 1.21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants