-
Notifications
You must be signed in to change notification settings - Fork 2.1k
core-services: drop machine-os-content references for 4.16+ #49157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That image isn't actually used in the cluster and will be removed from the release payload soon. See also https://issues.redhat.com/browse/MCO-392.
3511b3c to
4614cdf
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
IIUC, I think we will actually want to merge this at some point after we flip the switch again to not publish a machine-os-content image in the payload. This PR is removing the m-o-c from the list of tags to exclude from the OKD/origin releases. We want to keep excluding it while it still exists. Doing it after the m-o-c no longer exists would just be an aesthetic cleanup. /hold |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This won't be necessary once we stop mirroring images from ocp to origin altogether: #49084 |
|
/uncc |
|
/close |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jlebon: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
That image isn't actually used in the cluster and will be removed from the release payload soon.
See also https://issues.redhat.com/browse/MCO-392.