Skip to content

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Feb 22, 2024

That image isn't actually used in the cluster and will be removed from the release payload soon.

See also https://issues.redhat.com/browse/MCO-392.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 22, 2024
That image isn't actually used in the cluster and will be removed from
the release payload soon.

See also https://issues.redhat.com/browse/MCO-392.
@jlebon jlebon force-pushed the pr/moc-prune-core-services branch from 3511b3c to 4614cdf Compare February 22, 2024 21:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jlebon: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jlebon
Copy link
Member Author

jlebon commented Feb 26, 2024

IIUC, I think we will actually want to merge this at some point after we flip the switch again to not publish a machine-os-content image in the payload. This PR is removing the m-o-c from the list of tags to exclude from the OKD/origin releases. We want to keep excluding it while it still exists. Doing it after the m-o-c no longer exists would just be an aesthetic cleanup.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Contributor

This won't be necessary once we stop mirroring images from ocp to origin altogether: #49084

@smg247
Copy link
Member

smg247 commented Mar 11, 2024

/uncc

@openshift-ci openshift-ci bot removed the request for review from smg247 March 11, 2024 13:39
@jlebon
Copy link
Member Author

jlebon commented Mar 14, 2024

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon closed this Mar 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@jlebon: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants