-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Drop a bunch of machine-os-content references #48526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's long been deprecated now and nothing should be relying on it anymore. See also https://issues.redhat.com/browse/MCO-392.
That image isn't actually used in the cluster. We already have code in these same files to update the real image that gets used (`rhel-coreos`), so let's just drop these references. See also openshift/kubernetes#1805 (comment) and following. See also https://issues.redhat.com/browse/MCO-392.
…cationruns.ci.openshift.io` CRD Purely cosmetic, but `machine-os-content` is not really a good example name anymore given that it's deprecated. See also https://issues.redhat.com/browse/MCO-392.
That image isn't actually used in the cluster and will be removed from the release payload soon. See also https://issues.redhat.com/browse/MCO-392.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 139 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
OK, so I know this is kinda cutting across lots of different teams, and I can certainly split it into multiple PRs if preferred. Though at the same time, doing it this way allows us to keep the conversation in one place, which is helpful as this effort is honestly 90% about coordination. There's also this reference:
which I didn't touch because I'm not sure exactly what that is. Maybe @hongkailiu can chime in for that one. |
|
@soltysh Can we run any test here to ensure that this doesn't break O/K ci ? |
|
@jlebon: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It's long been deprecated now and nothing should be relying on it
anymore.
See individual commits for details.
See also https://issues.redhat.com/browse/MCO-392.