Skip to content

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Feb 6, 2024

It's long been deprecated now and nothing should be relying on it
anymore.

See individual commits for details.

See also https://issues.redhat.com/browse/MCO-392.

It's long been deprecated now and nothing should be relying on it
anymore.

See also https://issues.redhat.com/browse/MCO-392.
That image isn't actually used in the cluster. We already have
code in these same files to update the real image that gets used
(`rhel-coreos`), so let's just drop these references.

See also openshift/kubernetes#1805 (comment)
and following.

See also https://issues.redhat.com/browse/MCO-392.
…cationruns.ci.openshift.io` CRD

Purely cosmetic, but `machine-os-content` is not really a good example
name anymore given that it's deprecated.

See also https://issues.redhat.com/browse/MCO-392.
That image isn't actually used in the cluster and will be removed from
the release payload soon.

See also https://issues.redhat.com/browse/MCO-392.
@openshift-ci openshift-ci bot requested review from deads2k and deepsm007 February 6, 2024 22:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
Once this PR has been reviewed and has the lgtm label, please assign deads2k, jmguzik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jlebon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-okd-machine-os-release-4.17-e2e-aws-crun openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-aws-ovn openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-gcp openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-gcp-upgrade openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-ovirt openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-vsphere openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-images openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-aws-crun openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-gcp openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-gcp-upgrade openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-ovirt openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-vsphere openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-images openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-crun openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-ovn openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-gcp openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-gcp-upgrade openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-ovirt openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-vsphere openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-images openshift/okd-machine-os presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.16-artifacts openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.16-configmap-scale openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.16-e2e-agnostic-ovn-cmd openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-release-4.16-e2e-aws openshift/kubernetes presubmit Ci-operator config changed

A total of 139 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jlebon
Copy link
Member Author

jlebon commented Feb 6, 2024

OK, so I know this is kinda cutting across lots of different teams, and I can certainly split it into multiple PRs if preferred. Though at the same time, doing it this way allows us to keep the conversation in one place, which is helpful as this effort is honestly 90% about coordination.

There's also this reference:

- --testImagesDistributorOptions.additional-image-stream=rhcos/machine-os-content

which I didn't touch because I'm not sure exactly what that is. Maybe @hongkailiu can chime in for that one.

@sinnykumari
Copy link
Contributor

@soltysh Can we run any test here to ensure that this doesn't break O/K ci ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/build-farm/build10-dry 4782116 link true /test build10-dry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlebon
Copy link
Member Author

jlebon commented Feb 22, 2024

OK, split this into separate PRs to make this easier to go through.
#49155
#49156
#49157

@jlebon jlebon closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants