Skip to content

Conversation

@LorbusChris
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from ausil and lmzuccarelli February 21, 2024 18:17
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@openshift-ci-robot
Copy link
Contributor

@LorbusChris, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 21, 2024
@lmzuccarelli
Copy link
Contributor

@LorbusChris - as mentioned this PR has high priority so from my perspective the sooner it gets merged the better

@lmzuccarelli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@vrutkovs
Copy link
Contributor

/hold

This breaks https://github.com/openshift/enhancements/blob/master/enhancements/okd-on-fedora-coreos-in-prow.md. It needs to be updated first along with a discussion on its effects at Arch meeting

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
@ausil
Copy link
Contributor

ausil commented Feb 22, 2024

We can not share ELS RHEL content in OKD; this is a necessary step to rectify the issue and to set up builds for OKD with CentOS Stream content.

@vrutkovs
Copy link
Contributor

We don't even know which exactly content is being shared, it may or may not be exactly the same as UBI RPMs. Lets hold off potentially destructive actions until the plan for further actions is discussed in enhancements, agreed by all parties (OKD community, 3rd party operators using these images and OpenShift architects).

@jupierce
Copy link
Contributor

Hold to be discussed in Slack, but:
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LorbusChris: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jupierce
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, lmzuccarelli, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Contributor Author

The enhancement will be updated in due time to reflect the new OKD image build process
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@LorbusChris: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 812ad8e into openshift:master Mar 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@LorbusChris: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_10 using file core-services/image-mirroring/openshift/mapping_origin_4_10
  • key mapping_origin_4_11 using file core-services/image-mirroring/openshift/mapping_origin_4_11
  • key mapping_origin_4_12 using file core-services/image-mirroring/openshift/mapping_origin_4_12
  • key mapping_origin_4_13 using file core-services/image-mirroring/openshift/mapping_origin_4_13
  • key mapping_origin_4_14 using file core-services/image-mirroring/openshift/mapping_origin_4_14
  • key mapping_origin_4_15 using file core-services/image-mirroring/openshift/mapping_origin_4_15
  • key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16
  • key mapping_origin_4_6 using file core-services/image-mirroring/openshift/mapping_origin_4_6
  • key mapping_origin_4_7 using file core-services/image-mirroring/openshift/mapping_origin_4_7
  • key mapping_origin_4_8 using file core-services/image-mirroring/openshift/mapping_origin_4_8
  • key mapping_origin_4_9 using file core-services/image-mirroring/openshift/mapping_origin_4_9
Details

In response to this:

/cc @ausil @lmzuccarelli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
rh-rahulshetty pushed a commit to rh-rahulshetty/release that referenced this pull request Mar 18, 2024
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants