openshift/okd-machine-os: drop machine-os-content reference #49155

jlebon · 2024-02-22T20:26:16Z

It's long been deprecated now and nothing should be relying on it anymore.

See also https://issues.redhat.com/browse/MCO-392.

vrutkovs · 2024-02-22T20:46:38Z

Needs make openshift-image-mirror-mappings, otherwise
/approve

/pj-rehearse pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-ovn

LorbusChris · 2024-02-23T06:27:41Z

/lgtm
/assign @jupierce

jupierce · 2024-02-26T17:22:34Z

/approve

LorbusChris · 2024-02-27T08:55:40Z

okd-machine-os doesn't yet have a release-4.16 branch, so let's rehearse on master
/pj-rehearse pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn

openshift-ci-robot · 2024-02-27T08:56:00Z

@LorbusChris, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

It's long been deprecated now and nothing should be relying on it anymore. See also https://issues.redhat.com/browse/MCO-392.

jlebon · 2024-02-27T15:52:10Z

Rebased!

jlebon · 2024-02-27T15:52:27Z

/pj-rehearse pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn

openshift-ci-robot · 2024-02-27T15:55:30Z

[REHEARSALNOTIFIER]
@jlebon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-okd-machine-os-release-4.17-e2e-aws-crun	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-aws-ovn	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-gcp	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-gcp-upgrade	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-ovirt	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-e2e-vsphere	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.17-images	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-crun	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-ovn	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-gcp	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-gcp-upgrade	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-ovirt	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-e2e-vsphere	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-release-4.16-images	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-aws-crun	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-gcp	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-gcp-upgrade	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-ovirt	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-e2e-vsphere	openshift/okd-machine-os	presubmit	Ci-operator config changed
pull-ci-openshift-okd-machine-os-master-images	openshift/okd-machine-os	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2024-02-27T16:00:31Z

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/okd-machine-os/release-4.16/e2e-aws-ovn	`5b0a81f`	link	unknown	`/pj-rehearse pull-ci-openshift-okd-machine-os-release-4.16-e2e-aws-ovn`
ci/rehearse/openshift/okd-machine-os/master/e2e-aws-ovn	`1c9df53`	link	unknown	`/pj-rehearse pull-ci-openshift-okd-machine-os-master-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs

/lgtm
/rehearsals ack

Thanks!

openshift-ci · 2024-02-27T16:18:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, jupierce, LorbusChris, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/okd-machine-os/OWNERS~~ [LorbusChris,jupierce,vrutkovs]
~~core-services/image-mirroring/openshift/OWNERS~~ [jupierce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrutkovs · 2024-02-27T16:22:09Z

/pj-rehearse ack

openshift-ci · 2024-02-27T16:54:10Z

@jlebon: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16
key mapping_origin_4_17 using file core-services/image-mirroring/openshift/mapping_origin_4_17

Details

In response to this:

It's long been deprecated now and nothing should be relying on it anymore.

See also https://issues.redhat.com/browse/MCO-392.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…t#49155) It's long been deprecated now and nothing should be relying on it anymore. See also https://issues.redhat.com/browse/MCO-392.

jlebon mentioned this pull request Feb 22, 2024

Drop a bunch of machine-os-content references #48526

Closed

openshift-ci bot requested review from LorbusChris and vrutkovs February 22, 2024 20:29

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024

jlebon force-pushed the pr/moc-prune-okd branch from 5b0a81f to 3b256f6 Compare February 22, 2024 21:29

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024

openshift-ci bot assigned jupierce and LorbusChris Feb 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024

openshift/okd-machine-os: drop machine-os-content reference

1c9df53

It's long been deprecated now and nothing should be relying on it anymore. See also https://issues.redhat.com/browse/MCO-392.

jlebon force-pushed the pr/moc-prune-okd branch from 3b256f6 to 1c9df53 Compare February 27, 2024 15:52

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024

vrutkovs approved these changes Feb 27, 2024

View reviewed changes

openshift-ci bot assigned vrutkovs Feb 27, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 27, 2024

openshift-merge-bot bot merged commit fbb0c67 into openshift:master Feb 27, 2024

openshift/okd-machine-os: drop machine-os-content reference #49155

openshift/okd-machine-os: drop machine-os-content reference #49155

Uh oh!

Conversation

jlebon commented Feb 22, 2024

Uh oh!

vrutkovs commented Feb 22, 2024

Uh oh!

LorbusChris commented Feb 23, 2024

Uh oh!

jupierce commented Feb 26, 2024

Uh oh!

LorbusChris commented Feb 27, 2024

Uh oh!

openshift-ci-robot commented Feb 27, 2024

Uh oh!

jlebon commented Feb 27, 2024

Uh oh!

jlebon commented Feb 27, 2024

Uh oh!

openshift-ci-robot commented Feb 27, 2024

Uh oh!

openshift-ci bot commented Feb 27, 2024

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 27, 2024

Uh oh!

vrutkovs commented Feb 27, 2024

Uh oh!

openshift-ci bot commented Feb 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants