ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job #44751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Temporarily drop MachineAPI from Azure Cluster Bot job Like 69233e0 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job, 2023-10-11, openshift#44248), except for Azure, to try and reproduce [1]. The AWS change was subsequently reverted after testing in 4487924 (Revert "ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job", 2023-10-12, openshift#44296), and we expect this one to be reverted soon too. [1]: https://issues.redhat.com/browse/OCPBUGS-22266
openshift-ci-robot
added
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER] |
Contributor
|
/lgtm |
Contributor
|
/approve |
bparees
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
deleted the
cluster-bot-temporarily-drop-MachineAPI-enabled-capability-from-Azure
branch
robpblake
pushed a commit
to robpblake/release
that referenced
this pull request
Jan 11, 2024
…riodics: Temporarily drop MachineAPI from Azure Cluster Bot job (openshift#44751)" (openshift#47009) This reverts commit 428ef75.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 17, 2024
…er to "no-capabilities" Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…er to "no-capabilities" (#51070) Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, #49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, #48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, #44751) can restore it. [1]: openshift/installer@2dc1ef8
saifshaikh48
pushed a commit
to saifshaikh48/release
that referenced
this pull request
Apr 23, 2024
…er to "no-capabilities" (openshift#51070) Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like 69233e0 (#44248), except for Azure, to try and reproduce OCPBUGS-22266. The AWS change was subsequently reverted after testing in 4487924 (#44296), and we expect this one to be reverted soon too.