ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job #44248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Temporarily drop MachineAPI from AWS Cluster Bot job This was added here (among other places) in 365b996 (add MachineAPI cap to no-caps job, 2023-07-18, openshift#39892), because 4.14 and later None-set clusters need the MachineAPI capability enabled to allow installer/bootstrap-provisioned compute machines. But I need to be able to install a 4.13 None-capability cluster to test [1], and currently: launch 4.13,openshift/cluster-version-operator#981 aws,no-capabilities fails with [2]: level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: capabilities.additionalEnabledCapabilities[0]: Unsupported value: "MachineAPI": supported values: "CSISnapshot", "Console", "Insights", "NodeTuning", "Storage", "baremetal", "marketplace", "openshift-samples" In this commit, I'm dropping the MachineAPI injection from the AWS job. This should get my aws,no-capabilities invocation working on 4.13 while I test my pull, after which we can revert this change. In the meantime, folks who need to use no-capabilities Cluster Bot clusters to test 4.14 and later installs can use Azure or GCP or other non-AWS platforms. [1]: openshift/cluster-version-operator#981 [2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws-modern/1712189151484317696#1:build-log.txt%3A108
Contributor
|
/lgtm |
openshift-ci-robot
added
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER] |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
deleted the
cluster-bot-temporarily-drop-MachineAPI-enabled-capability
branch
Member
Author
|
openshift/cluster-version-operator#981 merged, so we can revert this now. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 12, 2023
…riodics: Temporarily drop MachineAPI from AWS Cluster Bot job (openshift#44248)" This reverts commit 69233e0.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 23, 2023
… Temporarily drop MachineAPI from Azure Cluster Bot job Like 69233e0 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job, 2023-10-11, openshift#44248), except for Azure, to try and reproduce [1]. The AWS change was subsequently reverted after testing in 4487924 (Revert "ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job", 2023-10-12, openshift#44296), and we expect this one to be reverted soon too. [1]: https://issues.redhat.com/browse/OCPBUGS-22266
openshift-ci bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
… Temporarily drop MachineAPI from Azure Cluster Bot job (#44751) Like 69233e0 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job, 2023-10-11, #44248), except for Azure, to try and reproduce [1]. The AWS change was subsequently reverted after testing in 4487924 (Revert "ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job", 2023-10-12, #44296), and we expect this one to be reverted soon too. [1]: https://issues.redhat.com/browse/OCPBUGS-22266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added here (among other places) in 365b996 (#39892), because 4.14 and later None-set clusters need the
MachineAPIcapability enabled to allow installer/bootstrap-provisioned compute machines. But I need to be able to install a 4.13None-capability cluster to test openshift/cluster-version-operator#981, and currently:fails with:
In this commit, I'm dropping the
MachineAPIinjection from the AWS job. This should get myaws,no-capabilitiesinvocation working on 4.13 while I test my pull, after which we can revert this change. In the meantime, folks who need to use no-capabilities Cluster Bot clusters to test 4.14 and later installs can use Azure or GCP or other non-AWS platforms.