ci-operator/config/openshift/release/*-4.16: Add CloudControllerManager to "no-capabilities" #51070
Conversation
…er to "no-capabilities" Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
openshift-ci
bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@wking: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
ci-4.16-e2e-aws-ovn-no-capabilities failed in the test suite, but it had a successful install, so: /pj-rehearse ack I'm not entirely sure what happened to the nightly-4.16-e2e-aws-ovn-ha-cert-rotation-suspend-30d run, but that one's already dead, so I doubt this change is making it worse. |
|
@wking: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…er to "no-capabilities" (openshift#51070) Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27, openshift#49708), because [1] explains: disabling CloudControllerManager is only supported on the Baremetal, None, or External platform with cloudControllerManager value none Besides the release periodics, I'm also touching the cluster-bot job definitions in openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on the packet-assisted job from 6544a41 (periodics: add assisted launch job, 2024-02-12, openshift#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context. This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from Azure Cluster Bot job, 2023-10-23, openshift#44751) can restore it. [1]: openshift/installer@2dc1ef8
3 participants
Similar to bbb31f9 (OCPQE-19978: Add CloudControllerManager Cap for v416, 2024-03-27 #49708), because openshift/installer@2dc1ef8 explains:
Besides the release periodics, I'm also touching the cluster-bot job definitions in
openshift-release-infra-periodics.yaml. AWS, Azure, and GCP will all need this new capability. I'm not clear on thepacket-assistedjob from 6544a41 (#48700), and I cannot figure out the Cluster Bot launch syntax to trigger that path. So for now, I'm adding the new capability there too, to avoid forking the configuration without a clearer understanding of the context.This change will break these Cluster Bot jobs for 4.15 and earlier, where the new capability does not exist or match the ClusterVersion enum. But they're already generally available, so folks may not need access, and if they do, hackery like 428ef75 (#44751) can restore it.