-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Switch CPO to use DOWNSTREAM_OWNERS #44277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CPO to use DOWNSTREAM_OWNERS #44277
Conversation
|
[REHEARSALNOTIFIER] |
|
For when the dependencies have all merged: |
|
/hold cancel |
|
/lgtm |
|
/approve |
|
@deepsm007, can you approve this? |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have DOWNSTREAM_OWNERS in all branches of interest: https://github.com/openshift/cloud-provider-openstack/pulls?q=is%3Apr+is%3Aclosed+%22CARRY%3A+Add+DOWNSTREAM_OWNERS%22
It's safe to merge.
/lgtm
/approve
|
@deepsm007, can you take a look here? It's a no-brainer really. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/lifecycle frozen |
|
@pierreprinetti: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle stale |
|
@deepsm007 can you PTAL when you get a chance? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, mandre, mdbooth, pierreprinetti, psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dulek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dulek: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold