Skip to content

Conversation

@dulek
Copy link
Contributor

@dulek dulek commented Oct 12, 2023

/hold

  • #223
  • We need it backported to all supported versions too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dulek: no rehearsable tests are affected by this change

@mdbooth
Copy link
Contributor

mdbooth commented Oct 12, 2023

For when the dependencies have all merged:
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@dulek
Copy link
Contributor Author

dulek commented Oct 13, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@pierreprinetti
Copy link
Member

/lgtm
/assign deepsm007

@dulek
Copy link
Contributor Author

dulek commented Oct 24, 2023

/approve

@dulek
Copy link
Contributor Author

dulek commented Oct 24, 2023

@deepsm007, can you approve this?

@dulek
Copy link
Contributor Author

dulek commented Oct 31, 2023

@smg247, since you've approved #44167, can you take a look here too?

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have DOWNSTREAM_OWNERS in all branches of interest: https://github.com/openshift/cloud-provider-openstack/pulls?q=is%3Apr+is%3Aclosed+%22CARRY%3A+Add+DOWNSTREAM_OWNERS%22

It's safe to merge.
/lgtm
/approve

@dulek
Copy link
Contributor Author

dulek commented Nov 28, 2023

@deepsm007, can you take a look here? It's a no-brainer really.

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2023
@pierreprinetti
Copy link
Member

/lifecycle frozen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 28, 2023

@pierreprinetti: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2023
@mandre
Copy link
Member

mandre commented Jan 3, 2024

@deepsm007 can you PTAL when you get a chance?

@mdbooth
Copy link
Contributor

mdbooth commented Jan 18, 2024

@DPTp @wking Could we get an approval on this? It's been languishing for a number of months now.

@psalajova
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mandre, mdbooth, pierreprinetti, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@dulek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 54ac983 into openshift:master Feb 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@dulek: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
Details

In response to this:

/hold

  • #223
  • We need it backported to all supported versions too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afaranha pushed a commit to afaranha/release that referenced this pull request Feb 8, 2024
ritmun pushed a commit to ritmun/release that referenced this pull request Feb 8, 2024
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants