Skip to content

Conversation

@dulek
Copy link

@dulek dulek commented Oct 12, 2023

We are now using DOWNSTREAM_OWNERS instead. We can restore OWNERS and OWNERS_ALIASES to upstream to avoid future merge conflicts.

/hold

mdbooth and others added 30 commits June 17, 2021 10:05
This reverts commit 68be840.

This release-specific commit should not be on master.
…penshift-4.9-ose-openstack-cinder-csi-driver

Updating ose-openstack-cinder-csi-driver images to be consistent with ART
imagebuilder used by OSBS/brew to create the product images does not
handle slashes in `COPY` commands well. See e.g.
openshift/imagebuilder#139. This commit
ensures the tree is actually present in the container.
…penshift-4.9-ose-openstack-cloud-controller-manager

Updating ose-openstack-cloud-controller-manager images to be consistent with ART
Add 'nouuid' mount option to all XFS mounts to be able to mount a volume
and its restored snapshot on the same node. Without the option, such a
mount fails, because XFS detects that two different volumes with the same
filesystem UUID are being mounted.
Use the same pattern across all Dockerfiles and remove duplicates.

Also remove the dockerfile for the deprecated Manila provisioner, for
which the image is not used any more in 4.9.
Bug 1996783: Bump to Go v1.16 and OCP v4.9
The file named `.ci-operator.yaml` governs which image is used in the
OpenShift CI. This has to be updated as well.
Bug 1996031: Merge upstream tag 'v1.22.0'
Bug 1988374: UPSTREAM: 1988374: Disable uuid checks on XFS (kubernetes#1614)
…penshift-4.10-ose-openstack-cloud-controller-manager

Updating ose-openstack-cloud-controller-manager images to be consistent with ART
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mdbooth, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dulek,mdbooth,stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Jan 18, 2024

/rename No-JIRA: CARRY: Restore OWNERS to upstream

@mandre
Copy link
Member

mandre commented Jan 18, 2024

/jira refresh

@openshift-ci-robot
Copy link

@mandre: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre
Copy link
Member

mandre commented Jan 18, 2024

/rename NO-JIRA: CARRY: Restore OWNERS to upstream

@mandre
Copy link
Member

mandre commented Jan 18, 2024

/retitle NO-JIRA: CARRY: Restore OWNERS to upstream

@openshift-ci openshift-ci bot changed the title CARRY: Restore OWNERS to upstream NO-JIRA: CARRY: Restore OWNERS to upstream Jan 18, 2024
@openshift-ci-robot
Copy link

@dulek: This pull request explicitly references no jira issue.

Details

In response to this:

We are now using DOWNSTREAM_OWNERS instead. We can restore OWNERS and OWNERS_ALIASES to upstream to avoid future merge conflicts.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024
@mdbooth
Copy link

mdbooth commented Jan 18, 2024

/verify-owners
/hold cancel

@mandre
Copy link
Member

mandre commented Jan 18, 2024

/hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@mandre
Copy link
Member

mandre commented Jan 18, 2024

this requires openshift/release#44277

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@mdbooth
Copy link

mdbooth commented Jan 18, 2024

this requires openshift/release#44277

We can still remove the hold because verify-owners won't pass until it merges.

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • jichenjc
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • kayrus
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • zetaab
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS

@dulek
Copy link
Author

dulek commented Feb 6, 2024

/hold cancel
/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@dulek
Copy link
Author

dulek commented Feb 6, 2024

/verify-owners

@mandre
Copy link
Member

mandre commented Feb 6, 2024

I'm about to rebase master on top of upstream release-1.29 and I've included this change already.
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 6, 2024
@mandre
Copy link
Member

mandre commented Feb 9, 2024

No longer needed after the rebase
/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Feb 9, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2024

@mandre: Closed this PR.

Details

In response to this:

No longer needed after the rebase
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.