-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Switch CAPO to use DOWNSTREAM_OWNERS #44167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CAPO to use DOWNSTREAM_OWNERS #44167
Conversation
1f8f51f to
f3fe953
Compare
|
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@mdbooth: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@mdbooth: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
If I understand correctly, with this patch, we can no longer merge in CAPO, except for main (thanks to openshift/cluster-api-provider-openstack#269). Shouldn't we have DOWNSTREAM_OWNERS in all branches before merging this patch? |
Answering to myself: we switched to MAPO in 4.11, and OCP 4.10 is now EOL, which means we no longer have legacy CAPO branches to maintain. We're fine. |
TODO:
/hold