Skip to content

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Oct 10, 2023

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 10, 2023
@openshift-ci openshift-ci bot requested review from deepsm007 and psalajova October 10, 2023 15:45
@mdbooth mdbooth force-pushed the capo-downstream-owners branch from 1f8f51f to f3fe953 Compare October 10, 2023 15:46
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mdbooth: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smg247
Copy link
Member

smg247 commented Oct 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented Oct 10, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 09be3f1 into openshift:master Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@mdbooth: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
Details

In response to this:

TODO:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth mdbooth deleted the capo-downstream-owners branch October 10, 2023 16:20
@mandre
Copy link
Member

mandre commented Oct 11, 2023

If I understand correctly, with this patch, we can no longer merge in CAPO, except for main (thanks to openshift/cluster-api-provider-openstack#269). Shouldn't we have DOWNSTREAM_OWNERS in all branches before merging this patch?

@mandre
Copy link
Member

mandre commented Oct 11, 2023

If I understand correctly, with this patch, we can no longer merge in CAPO, except for main (thanks to openshift/cluster-api-provider-openstack#269). Shouldn't we have DOWNSTREAM_OWNERS in all branches before merging this patch?

Answering to myself: we switched to MAPO in 4.11, and OCP 4.10 is now EOL, which means we no longer have legacy CAPO branches to maintain. We're fine.
That being said, we'll have to be careful when we make the same change for cloud-provider-openstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants