CNF-5643: Machine-API cap is always on #39892

qJkee · 2023-05-31T15:44:14Z

Enable machine api capability on CI and clusterbot jobs

openshift-ci · 2023-05-31T15:44:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

qJkee · 2023-05-31T15:45:34Z

/cc @wking
Is this the right way to have MachineAPI capability always be enabled?

openshift-ci-robot · 2023-06-01T17:45:19Z

@qJkee: This pull request references CNF-5643 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-07-01T19:20:52Z

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

qJkee · 2023-07-02T19:07:08Z

/remove-lifecycle stale

openshift-ci-robot · 2023-07-07T11:04:56Z

@qJkee: This pull request references CNF-5643 which is a valid jira issue.

Details

In response to this:

Enable machine api capability on CI and clusterbot jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-07T11:25:37Z

[REHEARSALNOTIFIER]
@qJkee: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

qJkee · 2023-07-07T14:22:39Z

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities

bparees · 2023-07-07T19:28:31Z

/approve

openshift-ci · 2023-07-14T12:37:36Z

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities	`ab08f01`	link	unknown	`/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bparees · 2023-07-17T21:58:14Z

/pj-rehearse ack

wking · 2023-07-17T22:01:40Z

rehearsal:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/39892/rehearse-39892-periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities/1677322547844091904/artifacts/e2e-aws-ovn-no-capabilities/gather-extra/artifacts/clusterversion.json | jq '.items[].status.capabilities'
{
  "enabledCapabilities": [
    "MachineAPI"
  ],
  "knownCapabilities": [
    "CSISnapshot",
    "Console",
    "Insights",
    "MachineAPI",
    "NodeTuning",
    "Storage",
    "baremetal",
    "marketplace",
    "openshift-samples"
  ]
}
$ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_release/39892/rehearse-39892-periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities/1677322547844091904/build-log.txt | grep -A5 'Failing tests'
Failing tests:

[sig-cli] oc basics can show correct whoami result with console [Skipped:NoOptionalCapabilities] [Suite:openshift/conformance/parallel]
[sig-node][apigroup:config.openshift.io] CPU Partitioning cluster platform workloads should be annotated correctly for DaemonSets [Suite:openshift/conformance/parallel]
[sig-storage] CSI Mock volume snapshot CSI Volume Snapshots [Feature:VolumeSnapshotDataSource] volumesnapshotcontent and pvc in Bound state with deletion timestamp set should not get deleted while snapshot finalizer exists [Skipped:NoOptionalCapabilities] [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-storage] CSI Mock volume snapshot CSI Volume Snapshots secrets [Feature:VolumeSnapshotDataSource] volume snapshot create/delete with secrets [Skipped:NoOptionalCapabilities] [Suite:openshift/conformance/parallel] [Suite:k8s]

openshift/origin#27481 is in flight to fiddle with the Skipped:NoOptionalCapabilities semantics, but even with those failing, that rehearsal is better than failing to install, which is what the periodic is doing without this pull.

/lgtm

wking

/lgtm

openshift-ci · 2023-07-17T22:08:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, qJkee, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/release/OWNERS~~ [bparees,wking]
~~ci-operator/jobs/openshift/release/OWNERS~~ [bparees,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-07-17T23:03:08Z

/retest-required

Remaining retests: 0 against base HEAD c07c6c0 and 2 for PR HEAD ab08f01 in total

openshift-ci · 2023-07-18T10:32:27Z

@qJkee: Updated the following 2 configmaps:

ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-release-master__ci-4.14.yaml using file ci-operator/config/openshift/release/openshift-release-master__ci-4.14.yaml
job-config-misc configmap in namespace ci at cluster app.ci using the following files:
- key openshift-release-infra-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-infra-periodics.yaml

Details

In response to this:

Enable machine api capability on CI and clusterbot jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… Temporarily drop MachineAPI from AWS Cluster Bot job This was added here (among other places) in 365b996 (add MachineAPI cap to no-caps job, 2023-07-18, openshift#39892), because 4.14 and later None-set clusters need the MachineAPI capability enabled to allow installer/bootstrap-provisioned compute machines. But I need to be able to install a 4.13 None-capability cluster to test [1], and currently: launch 4.13,openshift/cluster-version-operator#981 aws,no-capabilities fails with [2]: level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: capabilities.additionalEnabledCapabilities[0]: Unsupported value: "MachineAPI": supported values: "CSISnapshot", "Console", "Insights", "NodeTuning", "Storage", "baremetal", "marketplace", "openshift-samples" In this commit, I'm dropping the MachineAPI injection from the AWS job. This should get my aws,no-capabilities invocation working on 4.13 while I test my pull, after which we can revert this change. In the meantime, folks who need to use no-capabilities Cluster Bot clusters to test 4.14 and later installs can use Azure or GCP or other non-AWS platforms. [1]: openshift/cluster-version-operator#981 [2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws-modern/1712189151484317696#1:build-log.txt%3A108

… Temporarily drop MachineAPI from AWS Cluster Bot job (#44248) This was added here (among other places) in 365b996 (add MachineAPI cap to no-caps job, 2023-07-18, #39892), because 4.14 and later None-set clusters need the MachineAPI capability enabled to allow installer/bootstrap-provisioned compute machines. But I need to be able to install a 4.13 None-capability cluster to test [1], and currently: launch 4.13,openshift/cluster-version-operator#981 aws,no-capabilities fails with [2]: level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: capabilities.additionalEnabledCapabilities[0]: Unsupported value: "MachineAPI": supported values: "CSISnapshot", "Console", "Insights", "NodeTuning", "Storage", "baremetal", "marketplace", "openshift-samples" In this commit, I'm dropping the MachineAPI injection from the AWS job. This should get my aws,no-capabilities invocation working on 4.13 while I test my pull, after which we can revert this change. In the meantime, folks who need to use no-capabilities Cluster Bot clusters to test 4.14 and later installs can use Azure or GCP or other non-AWS platforms. [1]: openshift/cluster-version-operator#981 [2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws-modern/1712189151484317696#1:build-log.txt%3A108

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2023

openshift-ci bot requested a review from wking May 31, 2023 15:45

qJkee changed the title ~~[CNF-5643] Machine-API cap is always on~~ CNF-5643: Machine-API cap is always on Jun 1, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 1, 2023

qJkee marked this pull request as ready for review June 1, 2023 17:47

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2023

openshift-ci bot requested review from DennisPeriquet and deepsm007 June 1, 2023 17:47

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2023

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2023

qJkee force-pushed the CNF-5643 branch from 83ba2b5 to f8b85f0 Compare July 7, 2023 11:04

add MachineAPI cap to no-caps job

ab08f01

qJkee force-pushed the CNF-5643 branch from f8b85f0 to ab08f01 Compare July 7, 2023 11:24

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2023

wking approved these changes Jul 17, 2023

View reviewed changes

openshift-ci bot assigned wking Jul 17, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023

openshift-merge-robot merged commit 365b996 into openshift:master Jul 18, 2023

wking mentioned this pull request Oct 11, 2023

ci-operator/jobs/openshift/release/openshift-release-infra-periodics: Temporarily drop MachineAPI from AWS Cluster Bot job #44248

Merged

CNF-5643: Machine-API cap is always on #39892

CNF-5643: Machine-API cap is always on #39892

Uh oh!

Conversation

qJkee commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented May 31, 2023

Uh oh!

qJkee commented May 31, 2023

Uh oh!

openshift-ci-robot commented Jun 1, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jul 1, 2023

Uh oh!

qJkee commented Jul 2, 2023

Uh oh!

openshift-ci-robot commented Jul 7, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 7, 2023

Uh oh!

qJkee commented Jul 7, 2023

Uh oh!

bparees commented Jul 7, 2023

Uh oh!

openshift-ci bot commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented Jul 17, 2023

Uh oh!

wking commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 17, 2023

Uh oh!

openshift-ci-robot commented Jul 17, 2023

Uh oh!

openshift-ci bot commented Jul 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qJkee commented May 31, 2023 •

edited

Loading

openshift-ci-robot commented Jun 1, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 7, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Jul 14, 2023 •

edited

Loading

wking commented Jul 17, 2023 •

edited

Loading