Skip to content

CARRY: Add DOWNSTREAM_OWNERS #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Oct 10, 2023
Merged

CARRY: Add DOWNSTREAM_OWNERS #269

openshift-ci merged 1 commit into from
Oct 10, 2023

Conversation

@mdbooth
Copy link

@mdbooth mdbooth commented Oct 10, 2023

This will allow us to remove the carry and avoid merge conflicts on upstream OWNERS.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@mdbooth mdbooth mentioned this pull request Oct 10, 2023
Merged
1 task
@MaysaMacedo
Copy link

MaysaMacedo commented Oct 10, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@MaysaMacedo: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

pierreprinetti commented Oct 10, 2023

/lgtm

@mdbooth
Copy link
Author

mdbooth commented Oct 10, 2023

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@mdbooth
Copy link
Author

mdbooth commented Oct 10, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit d54c04c into openshift:main Oct 10, 2023
@mdbooth mdbooth deleted the downstream-owners branch October 10, 2023 16:03
@mandre mandre mentioned this pull request Jan 2, 2024
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@gyliu513 @pierreprinetti
Added kind example for openstack provider. (openshift#269)
4cfd1e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdbooth @MaysaMacedo @pierreprinetti