hypershift: cluster-image-registry-operator: add conformance presubmit test

[sjenning]

openshift/cluster-image-registry-operator#867 took out hypershift conformance, which blocks ART-built nightlies and feed the EC stream.

TRT investigation https://issues.redhat.com/browse/TRT-1193

Need conformance protection as this component can break hypershift in ways our standard e2e does not detect i.e. functioning internal image registry.

[openshift-ci-robot]

@sjenning, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 33bc3824298a1079b8771faa2507802b57dcd59b]' failed with out: fatal: reference is not a tree: 33bc3824298a1079b8771faa2507802b57dcd59b
and error exit status 128

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[flavianmissi]

Is there no way the standard e2e can cover this? feels like a simple test.
I understand and agree that the registry should not break hypershift, but I'm hesitant to adding more suites to the image registry and end up slowing down our merge rate even more... we have plenty of flakes with our current runs :/

[flavianmissi]

After f2f discussion I better understand the role of the conformance tests, so let's do this.
/lgtm

[sjenning]

/pj-rehearse ack

for reference, this is the testgrid dashboard monitoring the health of this job
https://testgrid.k8s.io/redhat-hypershift#4.14-aws-ovn-conformance

It blocks nightly promotions so, if it does break, we know almost immediately and it is urgent priority to fix it.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 465c1f9 and 2 for PR HEAD a6e467ee80afd1b1e9a2a93875db0ce22b7c124f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a673302 and 1 for PR HEAD a6e467ee80afd1b1e9a2a93875db0ce22b7c124f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 589e44d and 0 for PR HEAD a6e467ee80afd1b1e9a2a93875db0ce22b7c124f in total

[openshift-ci-robot]

/hold

Revision a6e467ee80afd1b1e9a2a93875db0ce22b7c124f was retested 3 times: holding

[flavianmissi]

@sjenning the failure seems legit, could you try running make jobs and see if you get any updates on the job related files?

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@sjenning: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift-conformance	openshift/cluster-image-registry-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-image-registry-operator-release-4.14-e2e-hypershift-conformance	openshift/cluster-image-registry-operator	presubmit	Presubmit changed
pull-ci-openshift-cluster-image-registry-operator-release-4.15-e2e-hypershift-conformance	openshift/cluster-image-registry-operator	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sjenning]

/hold cancel

[sjenning]

/pj-rehearse ack

[flavianmissi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-image-registry-operator/OWNERS [flavianmissi]
• ci-operator/jobs/openshift/cluster-image-registry-operator/OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment