Skip to content

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Aug 15, 2023

Bump openshift/api version with new capabilities

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8aff336 and 2 for PR HEAD 43a3157d036d8e17557df5651f1a286fcfd2fc79 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d55597a and 1 for PR HEAD 43a3157d036d8e17557df5651f1a286fcfd2fc79 in total

@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a012524 and 0 for PR HEAD 43a3157d036d8e17557df5651f1a286fcfd2fc79 in total

@qJkee
Copy link
Contributor Author

qJkee commented Aug 16, 2023

/hold because of openshift/cluster-image-registry-operator#899

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@qJkee qJkee changed the title gomod: bump openshift/api version OCPBUGS-17806: gomod: bump openshift/api version Aug 23, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 23, 2023
@openshift-ci-robot
Copy link
Contributor

@qJkee: This pull request references Jira Issue OCPBUGS-17806, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump openshift/api version with new capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 23, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Aug 23, 2023

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@wking
Copy link
Member

wking commented Aug 30, 2023

images:

# github.com/openshift/installer/pkg/asset/machines/azure
pkg/asset/machines/azure/machines.go:95:28: cannot use nil as string value in assignment
pkg/asset/machines/azure/machines.go:256:26: cannot use az (variable of type *string) as string value in struct literal

and likely other changes are required to get this compiling again.

@qJkee
Copy link
Contributor Author

qJkee commented Aug 30, 2023

/retest-required

@jianlinliu
Copy link
Contributor

Hope we can get this PR landed into nightly builds, this feature is failing QE's testing mentioned in openshift/release#42771

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 3eb48db link false /test e2e-azurestack
ci/prow/okd-e2e-aws-ovn 3eb48db link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 3eb48db link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 3eb48db link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor Author

qJkee commented Aug 31, 2023

/test e2e-azure-ovn

@qJkee
Copy link
Contributor Author

qJkee commented Aug 31, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
@patrickdillon
Copy link
Contributor

/lgtm
/skip

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@patrickdillon
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit dcf9967 into openshift:master Sep 1, 2023
@openshift-ci-robot
Copy link
Contributor

@qJkee: Jira Issue OCPBUGS-17806: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17806 has not been moved to the MODIFIED state.

Details

In response to this:

Bump openshift/api version with new capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants