Skip to content

IR-373: remove node-ca daemon #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 15, 2023
Merged

IR-373: remove node-ca daemon #867

openshift-merge-robot merged 1 commit into from
Aug 15, 2023

Conversation

@flavianmissi
Copy link
Member

@flavianmissi flavianmissi commented Jul 3, 2023

removes the node-ca daemon from fresh installs, as well as existing (upgraded) clusters.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2023 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references IR-373 which is a valid jira issue.

Details

In response to this:

removes the node-ca daemon from fresh installs, as well as existing (upgraded) clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2023
@flavianmissi
Copy link
Member Author

flavianmissi commented Jul 3, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@openshift-ci openshift-ci bot requested review from bparees and dmage July 3, 2023 14:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@flavianmissi flavianmissi changed the title IR-373: remove node-ca daemon WIP: IR-373: remove node-ca daemon Jul 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@flavianmissi flavianmissi force-pushed the IR-373 branch 2 times, most recently from d3d8696 to 18ee587 Compare July 4, 2023 11:55
flavianmissi
flavianmissi commented Aug 10, 2023
View reviewed changes
@flavianmissi flavianmissi force-pushed the IR-373 branch 2 times, most recently from 81ada0f to be1ec95 Compare August 11, 2023 12:00
@flavianmissi flavianmissi changed the title WIP: IR-373: remove node-ca daemon IR-373: remove node-ca daemon Aug 11, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2023
@flavianmissi
Copy link
Member Author

flavianmissi commented Aug 11, 2023

/unhold
this is ready for review

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2023
@dmage
Copy link
Contributor

dmage commented Aug 11, 2023

/lgtm

@dmage
Copy link
Contributor

dmage commented Aug 11, 2023

/refresh

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@dmage
Copy link
Contributor

dmage commented Aug 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@flavianmissi flavianmissi mentioned this pull request Aug 14, 2023
Merged
@flavianmissi
remove node-ca daemon
684ebd2 
removes the node-ca daemon from fresh installs, as well as existing
(upgraded) clusters.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@flavianmissi
Copy link
Member Author

flavianmissi commented Aug 14, 2023 •
edited
Loading

After QE tested this, I suspect the e2e failures are legit.openshift/machine-config-operator#3854 should fix it.

@xiuwang
Copy link

xiuwang commented Aug 15, 2023

/label qe-approved

Do upgrade test and regression test for #867 and openshift/machine-config-operator#3854 . No new issue found

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 15, 2023
@flavianmissi
Copy link
Member Author

flavianmissi commented Aug 15, 2023

/retest

@dmage
Copy link
Contributor

dmage commented Aug 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023 •
edited
Loading

@flavianmissi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt-sdn 684ebd2 link false /test e2e-ovirt-sdn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member Author

flavianmissi commented Aug 15, 2023

/retest

@stevsmit
Copy link
Member

stevsmit commented Aug 15, 2023

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 15, 2023
@flavianmissi
Copy link
Member Author

flavianmissi commented Aug 15, 2023

this does not affect end-users.
/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5852534 into openshift:master Aug 15, 2023
@flavianmissi flavianmissi deleted the IR-373 branch August 15, 2023 19:27
@sjenning sjenning mentioned this pull request Aug 16, 2023
Merged
@DennisPeriquet DennisPeriquet mentioned this pull request Aug 16, 2023
Closed
@sjenning sjenning mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@dmage dmage Awaiting requested review from dmage

Assignees

@dmage dmage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@flavianmissi @openshift-ci-robot @dmage @xiuwang @stevsmit @openshift-merge-robot