templates/installer/e2e-metal: use the rhcos.json from upi-installer image and fix bootstrap_ip retrieval #3612
Conversation
without the state file, terraform fails with error `The module root could not be found. There is nothing to output.`
…image to pick bootimage upi-installer image now includes the static rhcos.json [1], such that we that pickup the required bootimage asset location directly from it. [1]: openshift/installer#1673
openshift-ci-robot
added
size/S
abhinavdahiya
changed the title
|
/test pj-rehearse |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@abhinavdahiya: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…1.201911221453.0 Catching up with openshift/installer@a8e9991876 (rhcos: Bump to 43.81.201911221453.0, 2019-11-22, openshift/installer#2714) and its encryption fixes. Unfortunately we still don't have a way to expose the installer's recommended default, and I'm still opposed to reaching into the installer sources and looking in its internal rhcos.json like c85599a (templates/installer/e2e-metal: use the rhcos.json from upi-installer image to pick bootimage, 2019-04-26, openshift#3612) is doing for metal, because that's not what our users will be doing. Using the installer's tip AMI defaults is also not what users will be doing, but I'm not clear on how we can select the right branch in the templates to pull from the openshift-docs defaults [1,2,3] (which is what users will be doing). [1]: https://docs.openshift.com/container-platform/4.1/installing/installing_aws_user_infra/installing-aws-user-infra.html#installation-aws-user-infra-rhcos-ami_installing-aws-user-infra [2]: https://docs.openshift.com/container-platform/4.2/installing/installing_aws_user_infra/installing-aws-user-infra.html#installation-aws-user-infra-rhcos-ami_installing-aws-user-infra [3]: https://github.com/openshift/openshift-docs/blob/b24fe4684f8f6ba11cae92c5a779abbe4af57717/modules/installation-aws-user-infra-rhcos-ami.adoc#op-system-amis-for-the-aws-infrastructure
5 participants
without the state file, terraform fails with error
`The module root could not be found. There is nothing to output.
*templates/installer/e2e-metal: use the rhcos.json from upi-installer image to pick bootimage
upi-installer image now includes the static rhcos.json 1, such that we that pickup the required bootimage
asset location directly from it.
/cc @wking