Using proxy to run the tests remotely from the CI pod#19987
Using proxy to run the tests remotely from the CI pod#19987openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
f1aa9f2 to
285b0f1
Compare
|
/test pj-rehearse |
|
The websocket failures will be fixed by moving to gorilla/websockets.
|
Thanks @stbenjam ! It looks like there are other two test failures related similar to that one (the same found in different jobs): I'll check them also |
|
/test pj-rehearse |
7 similar comments
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/test pj-rehearse |
0defea2 to
4c13f8b
Compare
|
/test pj-rehearse |
|
Requires openshift/origin#26397 to fix |
There was a problem hiding this comment.
We should detect a proxy and skip these automatically: openshift/origin#26398
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
4c13f8b to
c249d08
Compare
|
/test pj-rehearse |
|
/test pj-rehearse |
4e31da6 to
4928d6d
Compare
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
/test pj-rehearse |
0b3038a to
54f8eaf
Compare
|
/retest |
03656ec to
8386604
Compare
|
/test pj-rehearse |
|
/test pj-rehearse |
fa33dcd to
67ee962
Compare
67ee962 to
27f1fcc
Compare
ardaguclu
left a comment
There was a problem hiding this comment.
That looks good to me
/retest
| # Skipping proxy related tests ([Skipped:Proxy]) is supported only for version greater than or equal to 4.10 | ||
| # For lower versions they must be skipped manually | ||
| if ! is_openshift_version_gte "4.10"; then | ||
| TEST_SKIPS="${TEST_SKIPS} |
There was a problem hiding this comment.
That means, we will not add serial-ipv6 and serial-compact for less than 4.10. I have never thought we would add them for <4.10 anyway.
There was a problem hiding this comment.
Do you maybe mean 4.8? This block is required until the proxy skipping feature will not be backported for 4.9 and 4.8 in openshift/origin
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, ardaguclu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andfasano: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently baremetal IPI workflows are running directly the tests from within the Packet instance. This PR removes such limitation by using a proxy to invoke directly the test runner from within the CI pod.
This will make the current step more similar to the standard
openshift-e2e-testone, and will allow to adopt it directly in future also for the baremetal IPI workflows.