Skip to content

Using proxy to run the tests remotely from the CI pod#19987

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:baremetal-remote-tests
Oct 20, 2021
Merged

Using proxy to run the tests remotely from the CI pod#19987
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:baremetal-remote-tests

Conversation

@andfasano
Copy link
Contributor

Currently baremetal IPI workflows are running directly the tests from within the Packet instance. This PR removes such limitation by using a proxy to invoke directly the test runner from within the CI pod.
This will make the current step more similar to the standard openshift-e2e-test one, and will allow to adopt it directly in future also for the baremetal IPI workflows.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2021
@openshift-ci openshift-ci bot requested review from honza and stbenjam July 7, 2021 13:30
@andfasano andfasano force-pushed the baremetal-remote-tests branch 2 times, most recently from f1aa9f2 to 285b0f1 Compare July 8, 2021 09:02
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Jul 9, 2021

The websocket failures will be fixed by moving to gorilla/websockets.

[sig-cli] Kubectl client Simple pod should support exec through an HTTP proxy [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less is interesting. It starts up a proxy server and tries to use that, I don't think we can nest two proxies, so this test should maybe be skipped.

@andfasano
Copy link
Contributor Author

andfasano commented Jul 9, 2021

The websocket failures will be fixed by moving to gorilla/websockets.

[sig-cli] Kubectl client Simple pod should support exec through an HTTP proxy [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less is interesting. It starts up a proxy server and tries to use that, I don't think we can nest two proxies, so this test should maybe be skipped.

Thanks @stbenjam ! It looks like there are other two test failures related similar to that one (the same found in different jobs):

* [sig-cli] Kubectl client Simple pod should support exec through kubectl proxy [Suite:openshift/conformance/parallel] [Suite:k8s]
* [sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it [Skipped:Disconnected] 

I'll check them also

@andfasano
Copy link
Contributor Author

/test pj-rehearse

7 similar comments
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2021
@andfasano andfasano force-pushed the baremetal-remote-tests branch from 0defea2 to 4c13f8b Compare August 11, 2021 16:00
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2021
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

andfasano commented Aug 12, 2021

Requires openshift/origin#26397 to fix [Serial] [sig-auth][Feature:OAuthServer] [RequestHeaders] [IdP] test RequestHeaders IdP [Suite:openshift/conformance/serial] failure (serial-ipv4)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should detect a proxy and skip these automatically: openshift/origin#26398

@andfasano
Copy link
Contributor Author

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano force-pushed the baremetal-remote-tests branch from 4c13f8b to c249d08 Compare August 20, 2021 13:32
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano force-pushed the baremetal-remote-tests branch from 4e31da6 to 4928d6d Compare September 23, 2021 13:40
@andfasano
Copy link
Contributor Author

/retest-required

@andfasano
Copy link
Contributor Author

/retest

1 similar comment
@andfasano
Copy link
Contributor Author

/retest

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano force-pushed the baremetal-remote-tests branch from 0b3038a to 54f8eaf Compare October 1, 2021 07:37
@andfasano
Copy link
Contributor Author

/retest

@andfasano andfasano force-pushed the baremetal-remote-tests branch 4 times, most recently from 03656ec to 8386604 Compare October 11, 2021 12:55
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano force-pushed the baremetal-remote-tests branch 4 times, most recently from fa33dcd to 67ee962 Compare October 19, 2021 10:48
@andfasano andfasano force-pushed the baremetal-remote-tests branch from 67ee962 to 27f1fcc Compare October 20, 2021 09:27
Copy link
Member

@ardaguclu ardaguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me

/retest

# Skipping proxy related tests ([Skipped:Proxy]) is supported only for version greater than or equal to 4.10
# For lower versions they must be skipped manually
if ! is_openshift_version_gte "4.10"; then
TEST_SKIPS="${TEST_SKIPS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means, we will not add serial-ipv6 and serial-compact for less than 4.10. I have never thought we would add them for <4.10 anyway.

Copy link
Contributor Author

@andfasano andfasano Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you maybe mean 4.8? This block is required until the proxy skipping feature will not be backported for 4.9 and 4.8 in openshift/origin

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-ovn-dualstack-trigger 29a33bd863ced0c9b0557fc4a1fdeb767f901b09 link /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-ovn-ipv6-trigger 4e31da60ad0317c26418e1b520fd1ad87ebebcc1 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-virtualmedia-trigger 4e31da60ad0317c26418e1b520fd1ad87ebebcc1 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-trigger 4e31da60ad0317c26418e1b520fd1ad87ebebcc1 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-virtualmedia 0b3038a6c2d668d232445fba7ffb7fb164a46e94 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-ovn-dualstack 0b3038a6c2d668d232445fba7ffb7fb164a46e94 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.9/e2e-metal-ipi-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.10/e2e-metal-ipi-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.10/e2e-metal-ipi-ovn-ipv6-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.9/e2e-metal-ipi-ovn-ipv6-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi-ovn-ipv6-trigger 0e61bbe53dba649da05f93278103bb3aede2660b link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.9/e2e-metal-ipi 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.10/e2e-metal-ipi 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi-ovn-ipv6 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi-serial-ipv4 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.10/e2e-metal-ipi-ovn-dualstack 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.8/e2e-metal-ipi-ovn-dualstack 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.9/e2e-metal-ipi-ovn-dualstack 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/release-4.9/e2e-metal-ipi-ovn-ipv6 5179656f576209d836626cec3651718c52cc3b38 link unknown /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-router 67ee9627309481da5f19e6d094d8efcda24535c1 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-serial-ipv4 67ee9627309481da5f19e6d094d8efcda24535c1 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-baremetal-operator/release-4.10/e2e-metal-ipi-ovn-ipv6 67ee9627309481da5f19e6d094d8efcda24535c1 link unknown /test pj-rehearse
ci/prow/pj-rehearse 27f1fcc link false /test pj-rehearse
ci/rehearse/openshift/metallb/release-4.9/metallb-l2-e2e-metal-ipi 27f1fcc link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-ocp-4.9-e2e-baremetal-cucushift-ipi 27f1fcc link unknown /test pj-rehearse
ci/rehearse/openshift/assisted-service/release-ocm-2.4/e2e-metal-assisted-operator-disconnected 27f1fcc link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-virtualmedia 27f1fcc link unknown /test pj-rehearse
ci/rehearse/openshift/ironic-static-ip-manager/release-4.9/e2e-metal-ipi 27f1fcc link unknown /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-ipv6 27f1fcc link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 04a07ba into openshift:master Oct 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

@andfasano: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key baremetalds-devscripts-gather-ref.yaml using file ci-operator/step-registry/baremetalds/devscripts/gather/baremetalds-devscripts-gather-ref.yaml
  • key baremetalds-e2e-test-commands.sh using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
  • key baremetalds-e2e-test-ref.yaml using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-ref.yaml
Details

In response to this:

Currently baremetal IPI workflows are running directly the tests from within the Packet instance. This PR removes such limitation by using a proxy to invoke directly the test runner from within the CI pod.
This will make the current step more similar to the standard openshift-e2e-test one, and will allow to adopt it directly in future also for the baremetal IPI workflows.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the baremetal-remote-tests branch October 20, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants