test: skip tests that won't work behind a proxy automatically by stbenjam · Pull Request #26398 · openshift/origin

stbenjam · 2021-08-12T18:59:38Z

The vast majority of the tests we run work and run fine through
an HTTP proxy to reach the target cluster under test, however a
handful of tests don't work. This adds a configuration to
openshift-tests to see if given the current proxy environment, we
would use a proxy to reach the API server. If so, then we skip
tests annotated with [Skip:Proxy].

deads2k · 2021-08-16T15:18:08Z

I'd like to get the proxy job clean more than I'd like every test available

/lgtm

stbenjam · 2021-08-16T15:20:34Z

/hold

I just want to check one thing before this lands

The vast majority of the tests we run work and run fine through an HTTP proxy to reach the target cluster under test, however a handful of tests don't work. This adds a configuration to openshift-tests to see if given the current proxy environment, we would use a proxy to reach the API server. If so, then we skip tests annotated with `[Skip:Proxy]`.

stbenjam · 2021-08-19T10:51:17Z

test/extended/util/cluster/cluster.go

+	url, _, err := rest.DefaultServerURL(clientConfig.Host, clientConfig.APIPath, schema.GroupVersion{}, false)
+	if err != nil {
+		return nil, err
+	}
+	state.APIURL = url


@deads2k Needs a lgtm again. I had this logic reversed and it was causing a panic 🤦

deads2k · 2021-08-23T12:32:26Z

/lgtm

openshift-ci · 2021-08-23T12:35:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stbenjam · 2021-08-26T01:03:33Z

/refresh

stbenjam · 2021-08-26T01:04:08Z

The DNM labels seem to be stuck, any chance you can remove them @deads2k?

stbenjam · 2021-09-07T10:33:41Z

/hold

stbenjam · 2021-09-07T10:33:49Z

/hold cancel

stbenjam · 2021-09-07T10:38:21Z

/retest

openshift-bot · 2021-09-07T11:05:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-07T14:42:54Z

@stbenjam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	`6916835`	link	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-09-07T14:43:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

mandre · 2021-12-03T09:07:51Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-12-03T09:11:49Z

@mandre: new pull request created: #26664

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano · 2021-12-20T14:10:38Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2021-12-20T14:13:31Z

@andfasano: #26398 failed to apply on top of branch "release-4.8":

Applying: test: skip tests that won't work behind a proxy automatically
Using index info to reconstruct a base tree...
M	test/extended/util/annotate/generated/zz_generated.annotations.go
M	test/extended/util/annotate/rules.go
M	test/extended/util/cluster/cluster.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/cluster/cluster.go
CONFLICT (content): Merge conflict in test/extended/util/cluster/cluster.go
Auto-merging test/extended/util/annotate/rules.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/rules.go
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: skip tests that won't work behind a proxy automatically
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam mentioned this pull request Aug 12, 2021

fix: add proxy support to OAuthServer tests #26397

Merged

openshift-ci bot requested review from adambkaplan and smarterclayton August 12, 2021 18:59

stbenjam mentioned this pull request Aug 12, 2021

Using proxy to run the tests remotely from the CI pod openshift/release#19987

Merged

stbenjam force-pushed the proxy branch 4 times, most recently from a94af2a to 6916835 Compare August 12, 2021 23:04

openshift-ci bot assigned deads2k Aug 16, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2021

stbenjam changed the title ~~test: skip tests that won't work behind a proxy automatically~~ [wip] test: skip tests that won't work behind a proxy automatically Aug 16, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021

stbenjam changed the title ~~[wip] test: skip tests that won't work behind a proxy automatically~~ test: skip tests that won't work behind a proxy automatically Aug 16, 2021

stbenjam force-pushed the proxy branch from 6916835 to 55f802a Compare August 19, 2021 10:45

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

stbenjam force-pushed the proxy branch from 55f802a to 60f42fe Compare August 19, 2021 10:49

stbenjam commented Aug 19, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021

andfasano mentioned this pull request Sep 1, 2021

Add Proxy CI for OpenStack platform openshift/release#20800

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021

stbenjam changed the title ~~test: skip tests that won't work behind a proxy automatically~~ [WIP] test: skip tests that won't work behind a proxy automatically Sep 7, 2021

stbenjam changed the title ~~[WIP] test: skip tests that won't work behind a proxy automatically~~ test: skip tests that won't work behind a proxy automatically Sep 7, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2021

openshift-merge-robot merged commit d85394b into openshift:master Sep 7, 2021

mandre mentioned this pull request Dec 3, 2021

openstack: set correct TEST_PROVIDER in e2e-test-commands openshift/release#24212

Merged

openshift-cherrypick-robot mentioned this pull request Dec 3, 2021

Bug 2033341: [release-4.9] test: skip tests that won't work behind a proxy automatically #26664

Merged

ardaguclu mentioned this pull request Jan 10, 2022

Bug 2038876: [release-4.8] test: skip tests that won't work behind a proxy automatically #26733

Merged

Conversation

stbenjam commented Aug 12, 2021

Uh oh!

deads2k commented Aug 16, 2021

Uh oh!

stbenjam commented Aug 16, 2021

Uh oh!

stbenjam Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

deads2k commented Aug 23, 2021

Uh oh!

openshift-ci bot commented Aug 23, 2021

Uh oh!

stbenjam commented Aug 26, 2021

Uh oh!

stbenjam commented Aug 26, 2021

Uh oh!

stbenjam commented Sep 7, 2021

Uh oh!

stbenjam commented Sep 7, 2021

Uh oh!

stbenjam commented Sep 7, 2021

Uh oh!

openshift-bot commented Sep 7, 2021

Uh oh!

openshift-ci bot commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 7, 2021

Uh oh!

mandre commented Dec 3, 2021

Uh oh!

openshift-cherrypick-robot commented Dec 3, 2021

Uh oh!

andfasano commented Dec 20, 2021

Uh oh!

openshift-cherrypick-robot commented Dec 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci bot commented Sep 7, 2021 •

edited

Loading