Skip to content

[WIP] Update baremetalds e2e test to use a proxy#18704

Closed
kirankt wants to merge 1 commit intoopenshift:masterfrom
kirankt:update-ipi-e2e-test-step
Closed

[WIP] Update baremetalds e2e test to use a proxy#18704
kirankt wants to merge 1 commit intoopenshift:masterfrom
kirankt:update-ipi-e2e-test-step

Conversation

@kirankt
Copy link
Contributor

@kirankt kirankt commented May 20, 2021

Currently the baremetalds-e2e-test workflow copies the openshift-tests binary and then utilizes ssh to connect to the remote host and run the binary. Since the addition of a proxy to the IPI tests, we should attempt to use the proxy to connect to the remote host. This PR attempts to use the proxy and removes remote execution of binaries using ssh.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kirankt
To complete the pull request process, please assign andfasano after the PR has been reviewed.
You can assign the PR to them by writing /assign @andfasano in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from sadasu and stbenjam May 20, 2021 02:37
@stbenjam
Copy link
Member

It's too big to test :-( I'd maybe just remove all the test skips, that should make it small enough to run. We'll get a good signal about the proxy approach, even if the now unskipped tests fail.

Add a new workflow to test baremetalds-e2e with proxy and a new job to run it

Rearrange directories and files

Re-run registry metadata

Remove test skips for now to test a minimal set

No need to fetch artifacts.

Add updated TEST_SKIPS to baremetalds-e2ev2-test

TEST_PROVIDER was not set correctly
@kirankt
Copy link
Contributor Author

kirankt commented May 26, 2021

/test pj-rehearse

3 similar comments
@kirankt
Copy link
Contributor Author

kirankt commented Jun 1, 2021

/test pj-rehearse

@kirankt
Copy link
Contributor Author

kirankt commented Jun 2, 2021

/test pj-rehearse

@kirankt
Copy link
Contributor Author

kirankt commented Jun 7, 2021

/test pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

@kirankt: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2021
@kirankt
Copy link
Contributor Author

kirankt commented Jun 10, 2021

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor

/test pj-rehearse

- chain: baremetalds-ipi-pre
test:
- ref: baremetalds-e2e-conf
- ref: baremetalds-e2ev2-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's sufficient the e2ev2 step, the workflow could be defined directly at the job level

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@kirankt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-baremetal-operator/master/e2e-metal-ipi-v2 2f127da link /test pj-rehearse
ci/prow/pj-rehearse 2f127da link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kirankt
Copy link
Contributor Author

kirankt commented Jul 7, 2021

Replace by: #19987

@kirankt kirankt closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants