Skip to content

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Jun 11, 2021

This patch will allow to run the first functional job
(openshift-e2e-openstack-csi workflow) on the
csi-driver-manila-operator repo, using the new OSP cloud (named
openstack-vh-mecha)

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2021
@openshift-ci openshift-ci bot requested review from adduarte and huffmanca June 11, 2021 13:41
@EmilienM EmilienM force-pushed the manila/step-registry branch from 8d25be7 to 78995d9 Compare June 16, 2021 19:30
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@EmilienM EmilienM force-pushed the manila/step-registry branch from 78995d9 to 0bf592d Compare June 16, 2021 19:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@EmilienM EmilienM changed the title WIP - Add conformance test to csi-driver-manila-operator Add openshift-e2e-openstack-csi workflow to csi-driver-manila-operator Jun 16, 2021
@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@EmilienM
Copy link
Member Author

/test e2e-openstack-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@EmilienM: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test ci-secret-bootstrap-config-validation
  • /test app-ci-config-dry
  • /test arm01-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-generator-config
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-ci-secret-bootstrap-config-validation
  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-arm01-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-boskos-config-generation
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-ci-secret-generator-config
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-hive-dry
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-secret-generator-config-valid
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test e2e-openstack-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM force-pushed the manila/step-registry branch from 2880674 to 88d9ea7 Compare June 16, 2021 21:12
@EmilienM
Copy link
Member Author

/test pj-rehearse

@EmilienM EmilienM force-pushed the manila/step-registry branch 2 times, most recently from a2a21ab to 133e944 Compare June 16, 2021 21:42
@EmilienM
Copy link
Member Author

/test pj-rehearse

@EmilienM EmilienM marked this pull request as draft June 17, 2021 01:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@EmilienM
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@EmilienM
Copy link
Member Author

/test pj-rehearse

@EmilienM EmilienM force-pushed the manila/step-registry branch from 133e944 to 5598f7b Compare June 17, 2021 15:18
@EmilienM EmilienM marked this pull request as ready for review June 17, 2021 15:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@EmilienM EmilienM force-pushed the manila/step-registry branch from 5598f7b to 47c0eb0 Compare June 17, 2021 15:25
@pierreprinetti
Copy link
Member

pierreprinetti commented Jun 17, 2021

@EmilienM
Please rebase onto #19392 once it's merged, to get cacert support

@EmilienM
Copy link
Member Author

/test pj-rehearse

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cacert is now handled by #19392; you should be able to remove this code

@EmilienM EmilienM force-pushed the manila/step-registry branch from 46d0df4 to e1ab51f Compare June 18, 2021 14:29
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilienM
Copy link
Member Author

Do we know why it skips so many of the Driver: manila.csi.openstack.org tests?

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/19179/rehearse-19179-pull-ci-openshift-csi-driver-manila-operator-master-e2e-openstack-csi/1405896008864370688

Good question, I'll re-run the tests once we deploy a most stable cloud...

@EmilienM
Copy link
Member Author

/test pj-rehearse

This patch will allow to run the first functional job
(openshift-e2e-openstack-csi workflow) on the
csi-driver-manila-operator repo, using the new OSP cloud (named
openstack-vh-mecha)

It also adds the necessary bits to load OC_CACERT if a certificate is
present. Our new cloud has self signed certificate so this is required.
@EmilienM EmilienM force-pushed the manila/step-registry branch from e1ab51f to 48ef0ce Compare June 21, 2021 15:58
@EmilienM
Copy link
Member Author

We're still working on stabilizing the mecha cloud for OpenStack.

@EmilienM
Copy link
Member Author

/test pj-rehearse

1 similar comment
@EmilienM
Copy link
Member Author

/test pj-rehearse

@EmilienM
Copy link
Member Author

/retest

@EmilienM
Copy link
Member Author

/test pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@EmilienM: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/sdn/release-4.9/e2e-aws-multitenant 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/ocs-operator/release-4.8/ocs-operator-bundle-e2e-aws 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-ovn-hybrid-step-registry 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.1/e2e-aws-builds 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-gcp-single-node 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.2/e2e-cmd 133e9447a8f086245f11341ea7cf0bc6e887c2ef link /test pj-rehearse
ci/rehearse/openshift/vsphere-problem-detector/release-4.9/e2e-vsphere 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-azure-ovn-dualstack 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/tnozicka/openshift-acme/master/e2e-cluster-wide 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-ovn-ipsec-step-registry 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.7/e2e-ovirt 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/machine-api-operator/release-4.9/e2e-azure-operator 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/tech-preview/e2e-operator 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/master/e2e-ovirt 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/release-4.9/e2e-aws-manual-oidc 46d0df4b2e8256764e9128ac2eb8e4a44f641b6f link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-proxy e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-workers-rhel7 e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/k8s-e2e-gcp e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-cilium e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/release-4.9/e2e-aws-ccm e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-csi-migration e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/azure-e2e-operator e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/aws-e2e-operator e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/redhat-developer/jenkins-operator/main/e2e e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/vsphere-e2e-operator e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/aws-e2e-upgrade e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-serial e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-fips e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/release-4.9/e2e-gcp-disruptive-ovn e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-csi e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.9/e2e-gcp-shared-vpc e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.9/e2e-gcp-upgrade e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-ovn-local-gateway e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-openstack-upgrade e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.9/e2e-aws-upgrade e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/cloud-provider-openstack/release-4.9/e2e-openstack-csi-cinder e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.5-e2e-ovirt e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-single-node e1ab51f2219a58dfc2044f156e47ea99dc985637 link /test pj-rehearse
ci/rehearse/openshift/csi-driver-manila-operator/master/e2e-openstack 48ef0ce link /test pj-rehearse
ci/prow/pj-rehearse 48ef0ce link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

The manila CSI test suite successfully passed 🎉
Let's keep the job non-voting until we stabilize the openstack cloud on which it runs.
Let's keep

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@mandre
Copy link
Member

mandre commented Jun 24, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@mandre
Copy link
Member

mandre commented Jun 24, 2021

/assign @jsafrane

@jsafrane
Copy link
Contributor

/approve
Can you please add the job to the CSI driver itself?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, jsafrane, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit c1bd397 into openshift:master Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@EmilienM: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-csi-driver-manila-operator-master.yaml using file ci-operator/config/openshift/csi-driver-manila-operator/openshift-csi-driver-manila-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-csi-driver-manila-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/csi-driver-manila-operator/openshift-csi-driver-manila-operator-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/openstack/csi/manila/OWNERS
    • key openshift-e2e-openstack-csi-manila-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/openstack/csi/manila/openshift-e2e-openstack-csi-manila-workflow.metadata.json
    • key openshift-e2e-openstack-csi-manila-workflow.yaml using file ci-operator/step-registry/openshift/e2e/openstack/csi/manila/openshift-e2e-openstack-csi-manila-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/storage/conf/csi-openstack-manila/OWNERS
    • key storage-conf-csi-openstack-manila-commands.sh using file ci-operator/step-registry/storage/conf/csi-openstack-manila/storage-conf-csi-openstack-manila-commands.sh
    • key storage-conf-csi-openstack-manila-ref.metadata.json using file ci-operator/step-registry/storage/conf/csi-openstack-manila/storage-conf-csi-openstack-manila-ref.metadata.json
    • key storage-conf-csi-openstack-manila-ref.yaml using file ci-operator/step-registry/storage/conf/csi-openstack-manila/storage-conf-csi-openstack-manila-ref.yaml
Details

In response to this:

This patch will allow to run the first functional job
(openshift-e2e-openstack-csi workflow) on the
csi-driver-manila-operator repo, using the new OSP cloud (named
openstack-vh-mecha)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jun 24, 2021

/approve
Can you please add the job to the CSI driver itself?

Yes, and we also want to run this job on csi-driver-nfs too. So we would need to add in a follow-up PR:

  • openshift/cloud-provider-openstack, for changes in pkg/csi/manila
  • openshift/csi-driver-nfs

@EmilienM
Copy link
Member Author

/approve
Can you please add the job to the CSI driver itself?

Yes, and we also want to run this job on csi-driver-nfs too. So we would need to add in a follow-up PR:

* openshift/cloud-provider-openstack, for changes in `pkg/csi/manila`

* openshift/csi-driver-nfs

done via #19769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants