-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add openshift-e2e-openstack-csi workflow to csi-driver-manila-operator #19179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openshift-e2e-openstack-csi workflow to csi-driver-manila-operator #19179
Conversation
...config/openshift/csi-driver-manila-operator/openshift-csi-driver-manila-operator-master.yaml
Outdated
Show resolved
Hide resolved
8d25be7 to
78995d9
Compare
78995d9 to
0bf592d
Compare
|
/test e2e-openstack-csi |
|
@EmilienM: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2880674 to
88d9ea7
Compare
|
/test pj-rehearse |
a2a21ab to
133e944
Compare
|
/test pj-rehearse |
|
/hold |
|
/test pj-rehearse |
133e944 to
5598f7b
Compare
5598f7b to
47c0eb0
Compare
...r/step-registry/storage/conf/csi-openstack-manila/storage-conf-csi-openstack-manila-ref.yaml
Outdated
Show resolved
Hide resolved
|
/test pj-rehearse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cacert is now handled by #19392; you should be able to remove this code
46d0df4 to
e1ab51f
Compare
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why it skips so many of the Driver: manila.csi.openstack.org tests?
...shift/csi-driver-manila-operator/openshift-csi-driver-manila-operator-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
Good question, I'll re-run the tests once we deploy a most stable cloud... |
|
/test pj-rehearse |
This patch will allow to run the first functional job (openshift-e2e-openstack-csi workflow) on the csi-driver-manila-operator repo, using the new OSP cloud (named openstack-vh-mecha) It also adds the necessary bits to load OC_CACERT if a certificate is present. Our new cloud has self signed certificate so this is required.
e1ab51f to
48ef0ce
Compare
|
We're still working on stabilizing the |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
|
/retest |
|
/test pj-rehearse |
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
The manila CSI test suite successfully passed 🎉
Let's keep the job non-voting until we stabilize the openstack cloud on which it runs.
Let's keep
|
/hold cancel |
|
/assign @jsafrane |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, jsafrane, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@EmilienM: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yes, and we also want to run this job on
|
done via #19769 |
This patch will allow to run the first functional job
(openshift-e2e-openstack-csi workflow) on the
csi-driver-manila-operator repo, using the new OSP cloud (named
openstack-vh-mecha)