openstack: Add cacert to clouds.yaml if provided #19392
Conversation
This change assumes that all steps in the job will mount SHARED_DIR to the same mountpoint, as it seems to currently be the case. That mountpoint is persisted in the cacert property of the clouds.yaml.
pierreprinetti
force-pushed
the
openstack_cacert
branch
from
204ca81 to
c615113
Compare
|
/cc @MaysaMacedo @mdbooth |
|
This lgtm in principal. Lets see what the test commit shows. |
pierreprinetti
changed the title
|
/test all |
There was a problem hiding this comment.
I'm trying to understand this change vs its commit message and I don't follow.
From my understanding here, we're switching the e2e-openstack-ipi in the installer project to use mecha cloud instead of managed vexxhost?
I hope not because mecha cloud isn't ready yet (we're having performances issues).
There was a problem hiding this comment.
nevermind, I was reading the PR commit message.
Still this cloud is unstable, don't use it yet please.
There was a problem hiding this comment.
The second commit (that is now removed) was a way to test the change; the change in this PR is just preparatory.
There was a problem hiding this comment.
Seems like the commit in question (c61511319841007c9df0b02df7927050bb67ea8b) is still part of the PR. Do you still want to remove it?
There was a problem hiding this comment.
The second commit (that is NOW removed) ...... 😬
pierreprinetti
force-pushed
the
openstack_cacert
branch
from
c615113 to
a56c706
Compare
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pierreprinetti: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mandre The failure doesn't look related to the change. Do you want to remove the hold? |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@pierreprinetti: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This change assumes that all steps in the job will mount SHARED_DIR to
the same mountpoint, as it seems to currently be the case.