Extend CSI driver testing for Manila & Cinder #19769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
...openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
* Add the Manila CSI driver tests against the cloud provider openstack project, only when Manila files are touched. * Only run the Cinder CSI tests when Cinder files are touched. * Add the Manila CSI drivr tests against the csi-driver-nfs project.
mandre
reviewed
Jun 28, 2021
Member
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/hold for CI to come back
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
/test pj-rehearse |
1 similar comment
Member
Author
|
/test pj-rehearse |
Member
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
|
@EmilienM: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project, only when Manila files are touched.