Skip to content

Comments

test: add baremetal provider#25994

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:provider
Mar 22, 2021
Merged

test: add baremetal provider#25994
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:provider

Conversation

@stbenjam
Copy link
Member

Baremetal IPI tests currently run without any provider set. While we're not so
interested in the cloud specific parts, we at least need a null provider
because loading the config also loads which SDN framework we're using,
and allows us to skip specific tests when using OVN. Currently the
tests that should be skipped on OVN, aren't -- they're filtered manually
by passing a list of tests to skip.

Baremetal IPI tests currently run without any provider set. While we're not so
interested in the cloud specific parts, we at least need a null provider
because loading the config also loads which SDN framework we're using,
and allows us to skip specific tests when using OVN.  Currently the
tests that should be skipped on OVN, aren't -- they're filtered manually
by passing a list of tests to skip.
@stbenjam
Copy link
Member Author

Tests marked Skipped:Network/OVNKubernetes aren't actually skipped in baremetal when running OVN since we don't set any provider - loading the provider config is what detects the SDN. More info in my attempt to re-enable all sig-network tests here openshift/release#16986

@stbenjam
Copy link
Member Author

/cc @smarterclayton @andfasano

@stbenjam
Copy link
Member Author

/retest

1 similar comment
@stbenjam
Copy link
Member Author

/retest

@stbenjam
Copy link
Member Author

/test e2e-gcp-disruptive

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants