Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm-ostree: Move more CI here #15461

Merged
merged 1 commit into from
Feb 4, 2021
Merged

rpm-ostree: Move more CI here #15461

merged 1 commit into from
Feb 4, 2021

Conversation

cgwalters
Copy link
Member

Let's do the build variants and unit testing in Prow, saving
the bare metal capacity of CentOS CI for our VM testing.

CC coreos/coreos-ci#23

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
This was referenced Feb 2, 2021
Merged
Closed
jlebon
jlebon approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through all the YAML goop, but it looks reasonable.
/lgtm

ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml
tests:
- artifact_dir: /tmp/artifacts
as: sanity
as: build
commands: rpm-ostree --version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this test given that the container build itself is already a prereq for the other tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ci-operator wants us to actually do something with the container image it built. It's kind of a placeholder for e.g. using this container image for actual cosa builds.

ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml Outdated
from: src
- artifact_dir: /tmp/artifacts
as: codestyle
commands: ./ci/ci-commitmessage-submodules.sh && ./ci/codestyle.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we should fold ci-commitmessage-submodules.sh into the latter IMO so we can keep the entrypoints here simple to make it easier to tweak on the rpm-ostree side in the future.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member

miabbott commented Feb 2, 2021

The error from ordered-prow-config job wants you to run make jobs

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@cgwalters cgwalters force-pushed the rpmostree-more branch 3 times, most recently from 440eb5c to 8edb7de Compare February 3, 2021 17:59
@cgwalters
Copy link
Member Author

OK this needs coreos/rpm-ostree#2533

@cgwalters
Copy link
Member Author

/retest

1 similar comment
@cgwalters
Copy link
Member Author

/retest

@cgwalters cgwalters force-pushed the rpmostree-more branch 3 times, most recently from 9828f66 to 5d7e130 Compare February 4, 2021 00:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2021 •
edited
Loading

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/coreos/rpm-ostree/master/sanity 14dec8b97a638229a176cde288258bbc0a5c4b15 link /test pj-rehearse
ci/rehearse/coreos/rpm-ostree/master/codestyle 20df175d5aa5b03bc1bc25b39b7d71dd65b45b97 link /test pj-rehearse
ci/rehearse/coreos/rpm-ostree/master/commit-validation 5d7e130521dc518df61410abc71a6d826e41d2de link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
rpm-ostree: Move more CI here
d3818a3 
Let's do the build variants and unit testing in Prow, saving
the bare metal capacity of CentOS CI for our VM testing.

CC coreos/coreos-ci#23
@cgwalters
Copy link
Member Author

cgwalters commented Feb 4, 2021 •
edited
Loading

OK I don't understand the setup of the src container with no origin remote etc. Need to ask DPTP about that. For now I just dropped the commit validation context from here.

DPTP: Are there docs on the exact setup of the git repository that I think Prow "clonerefs" creates? It doesn't seem we have an origin remote for example. For reference the code is here: https://github.com/coreos/rpm-ostree/blob/0a05e467e6d7620ed1c7bcb9b35352654af502c8/ci/ci-commitmessage-submodules.sh#L43 which is basically trying to do some validation on the git commit logs for the PR.

@sohankunkerkar
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon, sohankunkerkar, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 459aa89 into openshift:master Feb 4, 2021
@openshift-ci-robot
Copy link
Contributor

@cgwalters: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key coreos-rpm-ostree-master.yaml using file ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key coreos-rpm-ostree-master-presubmits.yaml using file ci-operator/jobs/coreos/rpm-ostree/coreos-rpm-ostree-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key coreos-rpm-ostree-master-presubmits.yaml using file ci-operator/jobs/coreos/rpm-ostree/coreos-rpm-ostree-master-presubmits.yaml

In response to this:

Let's do the build variants and unit testing in Prow, saving
the bare metal capacity of CentOS CI for our VM testing.

CC coreos/coreos-ci#23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters mentioned this pull request Feb 4, 2021
Merged
@petr-muller
Copy link
Member

DPTP: Are there docs on the exact setup of the git repository that I think Prow "clonerefs" creates? It doesn't seem we have an origin remote for example. For reference the code is here: https://github.com/coreos/rpm-ostree/blob/0a05e467e6d7620ed1c7bcb9b35352654af502c8/ci/ci-commitmessage-submodules.sh#L43 which is basically trying to do some validation on the git commit logs for the PR.

I'm only aware of these two docs for clonerefs, and neither of them specifies what you need. I don't think clonerefs currently even intends to give any guarantee about the git layout, only about what will be checked out as source code. I guess we could improve this upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@jlebon jlebon jlebon approved these changes

@miabbott miabbott Awaiting requested review from miabbott

Assignees

@jlebon jlebon

@sohankunkerkar sohankunkerkar

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cgwalters @openshift-bot @miabbott @sohankunkerkar @openshift-ci-robot @petr-muller @jlebon @travier @openshift-merge-robot