Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two small CI patches #2529

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Two small CI patches #2529

merged 2 commits into from
Feb 3, 2021

Conversation

cgwalters
Copy link
Member

@cgwalters
ci/build-check: Don't make install
ae3af60 
We may be running unprivileged (e.g. Prow), and `make install` needs to
be a uid 0 task.
@cgwalters
ci: Skip installing deps if non-root
699a579 
Assume in the pet/dev container case the user already has
deps.  And for Prow we're using the buildroot container which
should have them.
jlebon
jlebon approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

CI is fine for this, we're timing out in the compose tests, which merging this will help with.
/override continuous-integration/jenkins/pr-merge

@openshift-ci-robot
Copy link
Collaborator

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

CI is fine for this, we're timing out in the compose tests, which merging this will help with.
/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0581786 into coreos:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@lucab lucab Awaiting requested review from lucab

Assignees

@jlebon jlebon

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgwalters @openshift-ci-robot @jlebon @openshift-merge-robot