rust: Add license to our internal crates, check licenses in CI #2073
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rust/Cargo.toml
Outdated
| @@ -2,6 +2,10 @@ | |||
| name = "rpmostree-rust" | |||
| version = "0.1.0" | |||
| authors = ["Colin Walters <[email protected]>", "Jonathan Lebon <[email protected]>"] | |||
| # This is kind of a lie, we keep the Rust code MIT / Apache 2.0 but we also | |||
| # directly depend on the systemd crate, and really this is "license of the whole" | |||
| # as opposed "license of the individual code files" | |||
There was a problem hiding this comment.
I think I need some help with this. Why can't we put the MIT/Apache 2 license here? If we theoretically published this crate on crates.io, wouldn't that be the license we'd use? Re. systemd/libdnf, it's fine for MIT apps to link to LGPL libraries, no?
There was a problem hiding this comment.
So...yeah I kind of tried to do some handwaving here 👋 but you caught me 😉
Basically I tried setting it to "MIT / Apache 2.0" but cargo-lichking didn't like that and I didn't understand why and didn't want to spend the time on it at the time...
Just marking this one as WIP for now.
There was a problem hiding this comment.
OK I think actually the checker is right here; we want to make a claim on the final license, which is definitely LGPLv2+.
cgwalters
changed the title
cgwalters
force-pushed
the
license-internals
branch
2 times, most recently
from
1c50b83 to
3b09007
Compare
Start using https://github.com/Nemo157/cargo-lichking to validate our crates. I thought of this when I came across https://gitlab.com/woshilapin/with_tempdir/ and then noticed it was lgplv3, and wondered whether we e.g. had any incompatible licenses in our dependency graph. According to this (and looking at the output of `cargo lichking list`) we're good. But we need to keep this in mind.
cgwalters
force-pushed
the
license-internals
branch
from
3b09007 to
835af33
Compare
cgwalters
changed the title
|
OK I think this works, lifting WIP. But I also think we should move this job to Prow, so |
|
I did some more investigation of this space and I think coreos/bootupd#149 is better, will do another PR. |
I was playing with
https://github.com/Nemo157/cargo-lichking
in preparation for adding it to our CI.
I thought of this when I came across https://gitlab.com/woshilapin/with_tempdir/
and then noticed it was lgplv3, and wondered whether
we e.g. had any incompatible licenses in our dependency graph.
According to this (and looking at the output of
cargo lichking list)we're good. But we need to keep this in mind.