Skip to content

Conversation

@jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Dec 9, 2020

When overriding one env var (TEST_OPTIONS to get the rollback)
it seems you have to override them all even if they are already
defined in the workflow.

Signed-off-by: Jamo Luhrsen [email protected]

When overriding one env var (TEST_OPTIONS to get the rollback)
it seems you have to override them all even if they are already
defined in the workflow.

Signed-off-by: Jamo Luhrsen <[email protected]>
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Dec 9, 2020

just fyi that the rehearsal checks are gonna fail. original PR to get this job in also had that same trouble:
#13957

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Dec 9, 2020

@AlexNPavel , could you approve this please?

@hongkailiu
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, jluhrsen, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@jluhrsen: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.6-to-4.7 546bef2 link /test pj-rehearse
ci/prow/pj-rehearse 546bef2 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bb52794 into openshift:master Dec 9, 2020
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: Updated the following 2 configmaps:

  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
Details

In response to this:

When overriding one env var (TEST_OPTIONS to get the rollback)
it seems you have to override them all even if they are already
defined in the workflow.

Signed-off-by: Jamo Luhrsen [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen jluhrsen deleted the all-env-vars branch May 6, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants