Move upgrade-rollback job to use step registry

[jluhrsen]

Signed-off-by: Jamo Luhrsen [email protected]

[alvaroaleman]

/uncc
As this doesn't seem to be ready yet

[jluhrsen]

@alvaroaleman , I think it's ready now, but it's failing pj-rehearse which I think is expected at this point. You noted in another PR I have that UNRESOLVED_CONFIG doesn't work for pj-rehearse now and that there is a PR to get that working. I think it's this
one, right? openshift/ci-tools#1430

I'm hoping that moving this job to step registry will possibly give us more logs in order to debug https://bugzilla.redhat.com/show_bug.cgi?id=1893348

[jluhrsen]

/retest

[jluhrsen]

/retest

[jluhrsen]

/test pj-rehearse

[jluhrsen]

@alvaroaleman , I think it's ready now, but it's failing pj-rehearse which I think is expected at this point. You noted in another PR I have that UNRESOLVED_CONFIG doesn't work for pj-rehearse now and that there is a PR to get that working. I think it's this
one, right? openshift/ci-tools#1430

I'm hoping that moving this job to step registry will possibly give us more logs in order to debug https://bugzilla.redhat.com/show_bug.cgi?id=1893348

It looks like pj-rehearse is working for UNRESOLVED_CONFIG now, but I'm running in to something I don't understand. The
first rehearsal job failed because of some json config issue and I think it might be due to not putting quotes around the
version_bounds values. I updated the PR to use quotes, but the build_log is still showing it without quotes. The git checkout
file seems to be correct, so I can't explain it yet, but it seems like the rehearsal job is using an older version of this PR and not
the latest.

first job that ran when there were no quotes around version_bounds values:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/13957/rehearse-13957-release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.6-to-4.7/1333892772335194112

most recent job that looks the same to me:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/13957/rehearse-13957-release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.6-to-4.7/1333905879262564352

here is the current lines in the PR that have the quotes:
4b5dcfb#diff-f20da9fe69faf7e3bfa2be8f95367c6ef26e92e246cad6c78424807b153cf18fR5182

@alvaroaleman or @stevekuznetsov, any idea what I'm missing here?

[jluhrsen]

/test pj-rehearse

[vrutkovs]

abort-at here means "after 99 mins of waiting start an upgrade back to original release". Please update the docs accordingly.

[jluhrsen]

I wasn't exactly sure what 99 quantified, but I did find this:
https://github.com/openshift/openshift-tests/blob/e0d37add24c5dfc34497ad334abc6f02be96312a/cmd/extended-platform-tests/openshift-tests.go#L158

is it 99m or 99%. still learning here.

[vrutkovs]

I only skimmed through the PR, but how is it different from other openshift-upgrade workflows? Can we re-use the exising one and set TEST_OPTIONS instead?

[jluhrsen]

I only skimmed through the PR, but how is it different from other openshift-upgrade workflows? Can we re-use the exising one and set TEST_OPTIONS instead?

Thanks for the review. Yes, I would totally rather re-use the normal upgrade workflows. I didn't think to find a way to put TEST_OPTIONS in the job definition and it would be overwritten in the upgrade workflow. If that works, it would be much better.
let me see if I can try that.

[jluhrsen]

I only skimmed through the PR, but how is it different from other openshift-upgrade workflows? Can we re-use the exising one and set TEST_OPTIONS instead?

Thanks for the review. Yes, I would totally rather re-use the normal upgrade workflows. I didn't think to find a way to put TEST_OPTIONS in the job definition and it would be overwritten in the upgrade workflow. If that works, it would be much better.
let me see if I can try that.

@vrutkovs, how does it look now? I'm having trouble with the pj-rehearse job though. It seems like it's not actually using the changes from this PR to run that job.

[vrutkovs]

Looks good! IIRC env is being replaced, not merged, so check if copying all envs there works

[openshift-merge-robot]

@jluhrsen: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.6-to-4.7	0978acd	link	/test pj-rehearse
ci/prow/pj-rehearse	0978acd	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/jobs/openshift/release/OWNERS [AlexNPavel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jluhrsen: Updated the following 2 configmaps:

• job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
• job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
  • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml

Details

In response to this:

Signed-off-by: Jamo Luhrsen [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.