-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Define instance type for logging #14353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define instance type for logging #14353
Conversation
95c8fa8 to
2e23502
Compare
|
@jcantrill: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alanconway
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcantrill: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| commands: FAKE_HOME_DIR=/tmp/home LOG_DIR=/tmp/artifacts/logging-logs ARTIFACT_DIR=${ARTIFACT_DIR}/logging-artifacts make test-e2e-olm | ||
| env: | ||
| - default: m5.4xlarge | ||
| name: CLUSTER_NODE_TYPE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR merged before many of the rehearsals had completed, but I'd expect you'd need to also set some other environment variables to avoid clearing them. See #14184 for similar recovery. I have an internal ticket open with DPTP about rendering convenient docs for available environment variables here and similar. Anyhow, if your CI is doing what you want, you can ignore this. But if the jobs start behaving strangely, this may be why (and next time you may want to wait out the rehearsals and review their success before merging the release PR ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR merged before many of the rehearsals had completed, but I'd expect you'd need to also set some other environment variables to avoid clearing them.
Do we have any idea what might need to be set or is this simply trial and error?
This PR specifies the instance type for worker nodes when running logging jobs.
Depends on #14350
cc @wking
/assign @periklis