Skip to content

Conversation

@jcantrill
Copy link
Contributor

This PR specifies the instance type for worker nodes when running logging jobs.

Depends on #14350

cc @wking

/assign @periklis

@jcantrill jcantrill force-pushed the define_instance_type branch from 95c8fa8 to 2e23502 Compare December 15, 2020 21:07
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@openshift-merge-robot
Copy link
Contributor

@jcantrill: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-logging-operator/master/e2e-operator 2e23502 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cd198a7 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@jcantrill: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-cluster-logging-operator-master.yaml using file ci-operator/config/openshift/cluster-logging-operator/openshift-cluster-logging-operator-master.yaml
  • key openshift-elasticsearch-operator-master.yaml using file ci-operator/config/openshift/elasticsearch-operator/openshift-elasticsearch-operator-master.yaml
  • key openshift-elasticsearch-proxy-master.yaml using file ci-operator/config/openshift/elasticsearch-proxy/openshift-elasticsearch-proxy-master.yaml
  • key openshift-origin-aggregated-logging-master.yaml using file ci-operator/config/openshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master.yaml
Details

In response to this:

This PR specifies the instance type for worker nodes when running logging jobs.

Depends on #14350

cc @wking

/assign @periklis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

commands: FAKE_HOME_DIR=/tmp/home LOG_DIR=/tmp/artifacts/logging-logs ARTIFACT_DIR=${ARTIFACT_DIR}/logging-artifacts make test-e2e-olm
env:
- default: m5.4xlarge
name: CLUSTER_NODE_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR merged before many of the rehearsals had completed, but I'd expect you'd need to also set some other environment variables to avoid clearing them. See #14184 for similar recovery. I have an internal ticket open with DPTP about rendering convenient docs for available environment variables here and similar. Anyhow, if your CI is doing what you want, you can ignore this. But if the jobs start behaving strangely, this may be why (and next time you may want to wait out the rehearsals and review their success before merging the release PR ;).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR merged before many of the rehearsals had completed, but I'd expect you'd need to also set some other environment variables to avoid clearing them.

Do we have any idea what might need to be set or is this simply trial and error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants