Rename ci-operator *.json configs to *.yaml #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
Member
Author
|
/cc @stevekuznetsov |
Contributor
|
Let's talk about this on Tuesday (or if you feel confident, do it Monday) |
petr-muller
force-pushed
the
yaml-all-the-things
branch
from
cb45fdd to
4bbba56
Compare
openshift-ci-robot
added
size/L
petr-muller
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
To make processing and merge easier, I have removed the JSON-to-YAML reformatting commit from this PR. |
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
petr-muller
force-pushed
the
yaml-all-the-things
branch
from
4bbba56 to
f20761b
Compare
openshift-ci-robot
added
the
approved
openshift-bot
added
the
needs-rebase
petr-muller
force-pushed
the
yaml-all-the-things
branch
from
f20761b to
8320c16
Compare
openshift-bot
removed
the
needs-rebase
Contributor
@petr-muller: do you think the separation is necessary? I would rather do renaming + reformatting in one go, then communicate the change. |
Member
Author
It was easier to keep mergeable. Plus the renaming is sensitive because of the references from |
Contributor
|
Rebase and let's do it! |
petr-muller
force-pushed
the
yaml-all-the-things
branch
from
8320c16 to
8d1bc47
Compare
Member
Author
|
Rebased. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@petr-muller: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
Author
|
🤞 |
This was referenced Sep 10, 2018
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
This configures static IP for the bootstrap external NIC Requires openshift/installer#5787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching PRs for
ci-operator(openshift/ci-operator#121) andci-operator-prowgen(openshift/ci-operator-prowgen#9) were merged. This change renames all *.json ci-operator configs to YAML, and adjusts all tools and documentations that reference *.json files. JSON is a YAML subset so all existing tooling should continue to work.