add osa origin conformance e2e test via base images #1374

mjudeikis · 2018-09-06T12:08:49Z

Add e2e origin test to OSA cluster

mjudeikis · 2018-09-10T10:53:12Z

@Kargakis @jim-minter ready for first review

0xmichalis · 2018-09-10T10:57:49Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

Why not use the upstream openshift/origin-tests image?

need to check it if it does what we need to do. Never used it.

The image does not container uncompiled tests and code :/ does not work for us. it does not even has go in it.

It doesn't need to have go, does it? It should contain a binary with all the Origin conformance tests.

hmmm. found them ./ginkgo extended.test need to check if it contains all what we need. would be good to swap

0xmichalis · 2018-09-10T10:58:12Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

0xmichalis · 2018-09-10T10:58:17Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

0xmichalis · 2018-09-10T10:58:40Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

not needed?

0xmichalis · 2018-09-10T10:59:33Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure.yaml

why is this needed?

0xmichalis · 2018-09-10T11:00:08Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

comment needs update

0xmichalis · 2018-09-10T11:00:34Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

is this valid now?

I think so. But in different form :) will move

petr-muller · 2018-09-10T13:12:40Z

ci-operator/jobs/openshift/openshift-azure/openshift-openshift-azure-presubmits.yaml

This needs to be changed to master.yaml.

We have mass-renamed all ci-operator configuration files from .json to .yaml in #1336, because YAML is what ci-operator consumes now. JSON is a YAML subset so that the actual file content can stay like it is (we'll eventually mass-reformat them to the block style).

0xmichalis · 2018-09-10T13:31:12Z

ci-operator/templates/openshift-azure/README.md

smarterclayton · 2018-09-10T16:32:43Z

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml

@@ -0,0 +1,221 @@
+kind: Template


Why do you have cluster-launch-e2e-azure and cluster-launch-e2e-azure-conformance?

The first is meant to run openshift on azure specific e2e tests, the second is meant to run the origin conformance suite on a cluster deployed on azure.

0xmichalis · 2018-09-10T19:34:12Z

Let's see what falls out and fix it

/lgtm

openshift-ci-robot · 2018-09-10T19:35:06Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kargakis, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2018-09-10T19:39:34Z

@mjudeikis: Updated the following 4 configmaps:

prow-job-cluster-launch-e2e-azure configmap using the following files:
- key cluster-launch-e2e-azure.yaml using file ci-operator/templates/openshift-azure/cluster-launch-e2e-azure.yaml
plugins configmap using the following files:
- key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
job-config configmap using the following files:
- key openshift-openshift-azure-presubmits.yaml using file ci-operator/jobs/openshift/openshift-azure/openshift-openshift-azure-presubmits.yaml
prow-job-cluster-launch-e2e-azure-upgrade configmap using the following files:
- key cluster-launch-e2e-azure-upgrade.yaml using file ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-upgrade.yaml

Details

In response to this:

Add e2e origin test to OSA cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

It was changed from master to main recently

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2018

openshift-ci-robot requested review from jim-minter and kwoodson September 6, 2018 12:08

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2018

mjudeikis mentioned this pull request Sep 6, 2018

not all pipeline tags available to templates through $LOCAL_IMAGE_* openshift/ci-operator#131

Closed

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2018

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch 5 times, most recently from 6a008de to f4665eb Compare September 10, 2018 10:43

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2018

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from f4665eb to 813c710 Compare September 10, 2018 10:44

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2018

mjudeikis changed the title ~~[wip] add osa e2e test via base images~~ add osa origin conformance e2e test via base images Sep 10, 2018

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2018

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed?

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure.yaml Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/cluster-launch-e2e-azure-conformance.yaml Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment needs update

0xmichalis reviewed Sep 10, 2018

View reviewed changes

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from 813c710 to 49ee40b Compare September 10, 2018 13:01

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2018

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from 49ee40b to eba71db Compare September 10, 2018 13:03

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2018

petr-muller reviewed Sep 10, 2018

View reviewed changes

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from eba71db to b95c19b Compare September 10, 2018 13:25

0xmichalis reviewed Sep 10, 2018

View reviewed changes

ci-operator/templates/openshift-azure/README.md Outdated

Copy link

Contributor

0xmichalis Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is/are/

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch 2 times, most recently from 06d45d4 to fabba7b Compare September 10, 2018 14:52

add osa e2e conformance test via base images

bcb2e82

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from fabba7b to bcb2e82 Compare September 10, 2018 14:54

smarterclayton reviewed Sep 10, 2018

View reviewed changes

move to generic format for tests

6e83522

mjudeikis force-pushed the feature/osa-e2e-test-boilerplate branch from b1ea847 to 6e83522 Compare September 10, 2018 19:06

openshift-ci-robot assigned 0xmichalis Sep 10, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018

0xmichalis added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018

openshift-merge-robot merged commit f941165 into openshift:master Sep 10, 2018

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023

Fix default ironic image quay branch (openshift#1374)

fd16386

It was changed from master to main recently

add osa origin conformance e2e test via base images #1374

add osa origin conformance e2e test via base images #1374

Uh oh!

Conversation

mjudeikis commented Sep 6, 2018

Uh oh!

mjudeikis commented Sep 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xmichalis commented Sep 10, 2018

Uh oh!

openshift-ci-robot commented Sep 10, 2018

Uh oh!

openshift-ci-robot commented Sep 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants