Change the ci-operator config format to YAML

[petr-muller]

this should be merged only after openshift/ci-operator#121 is merged

/hold

Parse ci-operator config files as YAML instead of JSON. Generated jobs do not change, except for the ConfigMap part, where we generate the filename to always be a .yaml, so we won't be able to generate jobs for .json files in the directory-walking mode. (I need to fix this)

[petr-muller]

/cc @stevekuznetsov

[stevekuznetsov]

so we won't be able to generate jobs for .json files in the directory-walking mode. (I need to fix this)

I don't understand this -- care to elaborate?

[stevekuznetsov]

/lgtm

[petr-muller]

I don't understand this -- care to elaborate?

I will rectify the underlying problem, but to explain: When passed --from-dir, the generator walks the directory and searches for all *.json (before) / *.yaml (after) files there. It considers its filename, without extension, to be a branch name. Based on the branch name, it then generates the jobs, including this part:

- name: CONFIG_SPEC
  valueFrom:
    configMapKeyRef:
      key: branch.yaml

The key: branch.yaml part should match the source filename, but the source filename is not stored anywhere, just the branch part is, and the key: branch.yaml is generated simply by sprintf("%s.yaml"). Therefore, in the --from-dir mode, it needs to ignore *.json files because it would still generate key: <name>.yaml for such files, which would be broken. If the generator wants to support legacy json files (or even YAML files with the .yml suffix), it will need to correctly propagate full filename to this field.

Which is what I will do in next 20 minutes :)

[petr-muller]

Fixed now. The diff is slightly obfuscated by 6620518 which just collapses all those string, string, string, string to a struct. I can PR is separately if you want.

[stevekuznetsov]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[petr-muller]

/hold cancel