[DownstreamMerge] Bug 2026461: 4-4-22 merge by trozet · Pull Request #1010 · openshift/ovn-kubernetes

trozet · 2022-03-24T20:37:42Z

Includes retry pod deletion
Removing completed pods

Introduce /retest-failed, /cancel, /help command. The retest action now comments on pull requests when a rerun fails. Signed-off-by: Andreas Karis <ak.karis@gmail.com>

Github released the rerun-failed-jobs feature a couple of days ago. Reverts commit 73eedd3 partially minus the go version bump and minus the useful cache for the master image and rhe PR image. For everything else, use github's built-in feature. Signed-off-by: Andreas Karis <ak.karis@gmail.com>

Let's rename ovnNBLSPDel to delLSPOps since this function no longer actually deletes anything and is only returning the ops. Also change the logic a bit: 1) Validate LSP first. Get the LSP from ovsdb cache. If the LSP doesn't exist, nothing to do, return nil. 2) Get the UUID of the logical switch from logical switch manager. If this fails we know the switch must exist, because the LSP exists. Check OVN cache. If the switch is now gone, then we know the LSP must also be gone, return nil. Finally if Switch was found and LSP was validated, send delete op. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

Let's retry if deleteLogicalPort fails and ensure we clean up lsp to avoid duplicate lsp situations. In order to do this, let's return the errors if deletion fails instead of silently logging errors. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

…lure Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> Idea-Credit: Timothy Rozet<trozet@redhat.com>

…ests Test "should have ipv4 and ipv6 node podCIDRs" was removed from e2e tests in kubernetes 1.23 (kubernetes/kubernetes#105079), so no need to skip it. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>

Retry delete logical port on failures

Bug 1996128: Remove test "should have ipv4 and ipv6 node podCIDRs" from disabled tests

This pull request is to delete the logicial ports associated with a pod when a pods runs to completion. The intent of this change is to reduce the size of OVN databases by removing entries that are no longer needed. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com> Co-authored-by: Tim Rozet <trozet@redhat.com>

Get on port cache was returning the actual object in the cache instead of a copy. Signed-off-by: Tim Rozet <trozet@redhat.com>

With the update to deleteLogicalPort with pod completed status, there are several other places in the code that could have stale applications of the old pod IP. This commit modifies those to also remove the pod IP from their usage during pod update. Additionally, other places in the code rely on the logical port cache to get the portInfo. However, this may be removed after deleteLogicalPort. Therefore remove getting the logical port where IPs can be retrieved via the kapi pod object itself. Main paths affected: - Network Policy: updating port groups and addr sets - Namespace exgw: get pod ips from pod object, not port cache - Egress IP: update pod handling for completed pod - Hybrid Overlay: update pod handling for completed pod Signed-off-by: Tim Rozet <trozet@redhat.com>

There was a spot during pod update where if the update failed, we wouldn't add a retry entry. Signed-off-by: Tim Rozet <trozet@redhat.com>

…cceeded Scalability: Delete logical ports for completed pods

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>

openshift-ci · 2022-03-24T20:37:49Z

@trozet: This pull request references Bugzilla bug 2026461, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

[DownstreamMerge] Bug 2026461: 24-3-22 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tssurya · 2022-03-25T11:37:09Z

/lgtm

tssurya · 2022-03-25T11:37:19Z

/retest

Fixes the rebase glitch that happened in commit ovn-kubernetes/ovn-kubernetes@51a4b09 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

Fixes the rebase glitch that happened in ovn-kubernetes/ovn-kubernetes@ef85604#r69333487 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

trozet · 2022-03-25T13:05:42Z

/retest

API token can expire and we should not rely only on the token itself. If BearerTokenFile is provided it is periodically read and takes precedence over BearerToken. Signed-off-by: Patryk Diak <pdiak@redhat.com>

openshift-bot · 2022-04-05T13:01:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T13:14:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T14:14:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T14:51:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T15:27:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T16:51:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T18:39:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T19:15:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-05T21:28:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-06T00:37:46Z

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`7caaef7`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-azure-ovn	`7caaef7`	link	false	`/test e2e-azure-ovn`
ci/prow/e2e-vsphere-ovn	`7caaef7`	link	false	`/test e2e-vsphere-ovn`
ci/prow/e2e-vsphere-windows	`7caaef7`	link	false	`/test e2e-vsphere-windows`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-04-06T00:40:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T01:32:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T01:58:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T02:24:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T02:50:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T03:16:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T04:05:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T06:05:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T06:41:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T08:05:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T08:53:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T09:29:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T10:17:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-06T11:41:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

trozet · 2022-04-06T13:22:24Z

metal jobs are failing due to metal platform problems as well as this testcase:
openshift/origin#26975

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci · 2022-04-06T13:22:55Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

metal jobs are failing due to metal platform problems as well as this testcase:
openshift/origin#26975

/override ci/prow/e2e-metal-ipi-ovn-dualstack
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-06T13:25:06Z

@trozet: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#1010

Bugzilla bug 2026461 has been moved to the MODIFIED state.

Details

In response to this:

[DownstreamMerge] Bug 2026461: 4-4-22 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This reverts commit b25215b, reversing changes made to 22511de.

andreaskaris and others added 15 commits March 18, 2022 14:01

CI: Improvements to retest action

25065ad

Introduce /retest-failed, /cancel, /help command. The retest action now comments on pull requests when a rerun fails. Signed-off-by: Andreas Karis <ak.karis@gmail.com>

Make deletePodExternalGW and deleteGWRoutesForPod return error on fai…

3514740

…lure Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

Add retry logic for pod deletion

51a4b09

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> Idea-Credit: Timothy Rozet<trozet@redhat.com>

Remove test "should have ipv4 and ipv6 node podCIDRs" from disabled t…

5384db1

…ests Test "should have ipv4 and ipv6 node podCIDRs" was removed from e2e tests in kubernetes 1.23 (kubernetes/kubernetes#105079), so no need to skip it. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>

Merge pull request openshift#2787 from tssurya/retry-delLogicalPort

c838e94

Retry delete logical port on failures

Merge pull request openshift#2758 from ricky-rav/dev_bz_1996128

b2bf0fe

Bug 1996128: Remove test "should have ipv4 and ipv6 node podCIDRs" from disabled tests

Fixes unsafe get on port cache

b382400

Get on port cache was returning the actual object in the cache instead of a copy. Signed-off-by: Tim Rozet <trozet@redhat.com>

Fixes update pod to add retry entry on fail

b7c59d5

There was a spot during pod update where if the update failed, we wouldn't add a retry entry. Signed-off-by: Tim Rozet <trozet@redhat.com>

Merge pull request openshift#1121 from Billy99/billy99-del-logport-su…

f293c6a

…cceeded Scalability: Delete logical ports for completed pods

pods: Support hybrid clusters by skipping non-ovnk nodes

d54be04

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 24, 2022

openshift-ci bot requested review from abhat, anuragthehatter and jcaamano March 24, 2022 20:37

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022

openshift-ci bot assigned tssurya Mar 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022

tssurya added 2 commits March 25, 2022 13:47

Don't spawn goroutine for metrics recorder

5513148

Fixes the rebase glitch that happened in commit ovn-kubernetes/ovn-kubernetes@51a4b09 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

No need for dualstack feature gates

b6a0af0

Fixes the rebase glitch that happened in ovn-kubernetes/ovn-kubernetes@ef85604#r69333487 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

Add a way to provide API token file

8c0d840

API token can expire and we should not rely only on the token itself. If BearerTokenFile is provided it is periodically read and takes precedence over BearerToken. Signed-off-by: Patryk Diak <pdiak@redhat.com>

openshift-merge-robot merged commit b25215b into openshift:master Apr 6, 2022

JacobTanenbaum mentioned this pull request Apr 7, 2022

Bug 2070703: change networkpolicy ACLs to use "apply-after-lb" for egress #1020

Closed

deads2k added a commit to deads2k/ovn-kubernetes that referenced this pull request May 2, 2022

Revert "Merge pull request openshift#1010 from trozet/merge-3-24-22"

e5cdad0

This reverts commit b25215b, reversing changes made to 22511de.

Comments

Conversation

trozet commented Mar 24, 2022

Uh oh!

openshift-ci bot commented Mar 24, 2022

Uh oh!

tssurya commented Mar 25, 2022

Uh oh!

tssurya commented Mar 25, 2022

Uh oh!

trozet commented Mar 25, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-bot commented Apr 5, 2022

Uh oh!

openshift-ci bot commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

openshift-bot commented Apr 6, 2022

Uh oh!

trozet commented Apr 6, 2022

Uh oh!

openshift-ci bot commented Apr 6, 2022

Uh oh!

openshift-ci bot commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

openshift-ci bot commented Apr 6, 2022 •

edited

Loading